Changeset 38672 for trunk/src/wp-admin/plugins.php

Timestamp:

09/28/2016 07:53:07 PM (9 years ago)

Author:

afercia

Message:

Administration: Improve the usage of the button CSS classes.

Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

• Adds the button class to all primary buttons make them responsive
• Removes all secondary-button classes and replaces it with button when needed. button-secondary shouldn't be used and exists just for backward compatibility reasons
• Replaces classes inside submit_button() with a shorthand for some buttons, and use an empty string for the default button class. Passing button is unnecessary
• Adjusts get_submit_button() to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

File:

• trunk/src/wp-admin/plugins.php (modified) (2 diffs)

trunk/src/wp-admin/plugins.php

@@ -328 +328 @@
                     ?>
                     <?php wp_nonce_field('bulk-plugins') ?>
-                    <?php submit_button( $data_to_delete ? __( 'Yes, delete these files and data' ) : __( 'Yes, delete these files' ), 'button', 'submit', false ); ?>
+                    <?php submit_button( $data_to_delete ? __( 'Yes, delete these files and data' ) : __( 'Yes, delete these files' ), '', 'submit', false ); ?>
                 </form>
                 <?php
@@ -334 +334 @@
                 ?>
                 <form method="post" action="<?php echo $referer ? esc_url( $referer ) : ''; ?>" style="display:inline;">
-                    <?php submit_button( __( 'No, return me to the plugin list' ), 'button', 'submit', false ); ?>
+                    <?php submit_button( __( 'No, return me to the plugin list' ), '', 'submit', false ); ?>
                 </form>
             </div>