Changeset 38883 for trunk/src/wp-includes/rss.php

Timestamp:

10/24/2016 04:44:07 AM (8 years ago)

Author:

pento

Message:

General: Check to see that the PHP-XML module is enabled before using XML functions.

There are a handful of places where we don't check that the XML functions exist before we use them. Ubuntu's PHP 7 packages don't include PHP-XML by default, increasing the chance of this causing issues.

Props kraftbj, markoheijnen.
Fixes #37122.

File:

• trunk/src/wp-includes/rss.php (modified) (1 diff)

trunk/src/wp-includes/rss.php

@@ -61 +61 @@
     function __construct( $source ) {
 
-        # if PHP xml isn't compiled in, die
+        # Check if PHP xml isn't compiled
         #
-        if ( !function_exists('xml_parser_create') )
-            trigger_error( "Failed to load PHP's XML Extension. https://secure.php.net/manual/en/ref.xml.php" );
-
-        $parser = @xml_parser_create();
-
-        if ( !is_resource($parser) )
-            trigger_error( "Failed to create an instance of PHP's XML parser. https://secure.php.net/manual/en/ref.xml.php");
+        if ( ! function_exists('xml_parser_create') ) {
+            return trigger_error( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." );
+        }
+
+        $parser = xml_parser_create();
 
         $this->parser = $parser;