WordPress.org

Make WordPress Core


Ignore:
Timestamp:
10/24/2016 04:44:07 AM (3 years ago)
Author:
pento
Message:

General: Check to see that the PHP-XML module is enabled before using XML functions.

There are a handful of places where we don't check that the XML functions exist before we use them. Ubuntu's PHP 7 packages don't include PHP-XML by default, increasing the chance of this causing issues.

Props kraftbj, markoheijnen.
Fixes #37122.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-includes/rss.php

    r37985 r38883  
    6161    function __construct( $source ) {
    6262
    63         # if PHP xml isn't compiled in, die
     63        # Check if PHP xml isn't compiled
    6464        #
    65         if ( !function_exists('xml_parser_create') )
    66             trigger_error( "Failed to load PHP's XML Extension. https://secure.php.net/manual/en/ref.xml.php" );
    67 
    68         $parser = @xml_parser_create();
    69 
    70         if ( !is_resource($parser) )
    71             trigger_error( "Failed to create an instance of PHP's XML parser. https://secure.php.net/manual/en/ref.xml.php");
     65        if ( ! function_exists('xml_parser_create') ) {
     66            return trigger_error( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." );
     67        }
     68
     69        $parser = xml_parser_create();
    7270
    7371        $this->parser = $parser;
Note: See TracChangeset for help on using the changeset viewer.