Changeset 39506 for trunk/src/wp-includes/class-wp-customize-nav-menus.php

Timestamp:

12/05/2016 07:32:09 PM (7 years ago)

Author:

westonruter

Message:

Customize: Defer populating post_name for auto-draft posts in customized state until posts are published.

The ultimate post_name is stored in postmeta until the post is published. The get_page_by_path() function does not exclude auto-draft posts. Revert changes to wp_unique_post_slug() from [39411] which excluded auto-draft posts.

Props westonruter, dlh for testing, helen for testing.
See #38114, #38928.
Fixes #39078.

File:

• trunk/src/wp-includes/class-wp-customize-nav-menus.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-customize-nav-menus.php

@@ -804 +804 @@
             $postarr['post_name'] = sanitize_title( $postarr['post_title'] );
         }
+        if ( ! isset( $postarr['meta_input'] ) ) {
+            $postarr['meta_input'] = array();
+        }
+        $postarr['meta_input']['_customize_draft_post_name'] = $postarr['post_name'];
+        unset( $postarr['post_name'] );
 
         add_filter( 'wp_insert_post_empty_content', '__return_false', 1000 );
@@ -1193 +1198 @@
             foreach ( $post_ids as $post_id ) {
                 $target_status = 'attachment' === get_post_type( $post_id ) ? 'inherit' : 'publish';
+                $args = array(
+                    'ID' => $post_id,
+                    'post_status' => $target_status,
+                );
+                $post_name = get_post_meta( $post_id, '_customize_draft_post_name', true );
+                if ( $post_name ) {
+                    $args['post_name'] = $post_name;
+                }
 
                 // Note that wp_publish_post() cannot be used because unique slugs need to be assigned.
-                wp_update_post( array( 'ID' => $post_id, 'post_status' => $target_status ) );
+                wp_update_post( wp_slash( $args ) );
+
+                delete_post_meta( $post_id, '_customize_draft_post_name' );
             }
         }