Changeset 42119 for trunk/src/wp-includes/wp-db.php

Timestamp:

11/07/2017 12:29:26 AM (7 years ago)

Author:

pento

Message:

WPDB: Fix a PHP notice when AUTH_SALT is undefined.

In wpdb::placeholder_escape(), the key for hash_hmac() falls back to rand() when AUTH_SALT is undefined. hash_hmac() requires the key to be a string, however, so we need to cast it as such.

Props mkomar.
Fixes #42401.

File:

• trunk/src/wp-includes/wp-db.php (modified) (1 diff)

trunk/src/wp-includes/wp-db.php

@@ -1947 +1947 @@
             $algo = function_exists( 'hash' ) ? 'sha256' : 'sha1';
             // Old WP installs may not have AUTH_SALT defined.
-            $salt = defined( 'AUTH_SALT' ) ? AUTH_SALT : rand();
+            $salt = defined( 'AUTH_SALT' ) ? AUTH_SALT : (string) rand();
 
             $placeholder = '{' . hash_hmac( $algo, uniqid( $salt, true ), $salt ) . '}';