Changeset 45583 for trunk/src/wp-admin/includes/media.php

Timestamp:

07/01/2019 12:50:14 PM (6 years ago)

Author:

pento

Message:

Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments violations in wp-admin.

See #47632.

File:

• trunk/src/wp-admin/includes/media.php (modified) (14 diffs)

trunk/src/wp-admin/includes/media.php

@@ -288 +288 @@
 
     $time = current_time( 'mysql' );
-    if ( $post = get_post( $post_id ) ) {
+    $post = get_post( $post_id );
+    if ( $post ) {
         // The post date doesn't usually matter for pages, so don't backdate this upload.
         if ( 'page' !== $post->post_type && substr( $post->post_date, 0, 4 ) > 0 ) {
@@ -370 +371 @@
 
         // Use image exif/iptc data for title and caption defaults if possible.
-    } elseif ( 0 === strpos( $type, 'image/' ) && $image_meta = wp_read_image_metadata( $file ) ) {
-        if ( trim( $image_meta['title'] ) && ! is_numeric( sanitize_title( $image_meta['title'] ) ) ) {
-            $title = $image_meta['title'];
-        }
-
-        if ( trim( $image_meta['caption'] ) ) {
-            $excerpt = $image_meta['caption'];
+    } elseif ( 0 === strpos( $type, 'image/' ) ) {
+        $image_meta = wp_read_image_metadata( $file );
+        if ( $image_meta ) {
+            if ( trim( $image_meta['title'] ) && ! is_numeric( sanitize_title( $image_meta['title'] ) ) ) {
+                $title = $image_meta['title'];
+            }
+
+            if ( trim( $image_meta['caption'] ) ) {
+                $excerpt = $image_meta['caption'];
+            }
         }
     }
@@ -421 +425 @@
 
     $time = current_time( 'mysql' );
-    if ( $post = get_post( $post_id ) ) {
+    $post = get_post( $post_id );
+    if ( $post ) {
         if ( substr( $post->post_date, 0, 4 ) > 0 ) {
             $time = $post->post_date;
@@ -439 +444 @@
 
     // Use image exif/iptc data for title and caption defaults if possible.
-    if ( $image_meta = wp_read_image_metadata( $file ) ) {
+    $image_meta = wp_read_image_metadata( $file );
+    if ( $image_meta ) {
         if ( trim( $image_meta['title'] ) && ! is_numeric( sanitize_title( $image_meta['title'] ) ) ) {
             $title = $image_meta['title'];
@@ -693 +699 @@
     if ( ! empty( $_POST['attachments'] ) ) {
         foreach ( $_POST['attachments'] as $attachment_id => $attachment ) {
-            $post = $_post = get_post( $attachment_id, ARRAY_A );
+            $post  = get_post( $attachment_id, ARRAY_A );
+            $_post = $post;
 
             if ( ! current_user_can( 'edit_post', $attachment_id ) ) {
@@ -836 +843 @@
 
             $type = 'file';
-            if ( ( $ext = preg_replace( '/^.+?\.([^.]+)$/', '$1', $src ) ) && ( $ext_type = wp_ext2type( $ext ) )
-                && ( 'audio' == $ext_type || 'video' == $ext_type ) ) {
+            $ext  = preg_replace( '/^.+?\.([^.]+)$/', '$1', $src );
+            if ( $ext ) {
+                $ext_type = wp_ext2type( $ext );
+                if ( 'audio' == $ext_type || 'video' == $ext_type ) {
                     $type = $ext_type;
+                }
             }
 
@@ -1441 +1451 @@
             continue;
         }
-        if ( $item = get_media_item( $id, array( 'errors' => isset( $errors[ $id ] ) ? $errors[ $id ] : null ) ) ) {
+        $item = get_media_item( $id, array( 'errors' => isset( $errors[ $id ] ) ? $errors[ $id ] : null ) );
+        if ( $item ) {
             $output .= "\n<div id='media-item-$id' class='media-item child-of-$attachment->post_parent preloaded'><div class='progress hidden'><div class='bar'></div></div><div id='media-upload-error-$id' class='hidden'></div><div class='filename hidden'></div>$item\n</div>";
         }
@@ -1463 +1474 @@
     global $redir_tab;
 
-    if ( ( $attachment_id = intval( $attachment_id ) ) && $thumb_url = wp_get_attachment_image_src( $attachment_id, 'thumbnail', true ) ) {
-        $thumb_url = $thumb_url[0];
-    } else {
-        $thumb_url = false;
+    $thumb_url     = false;
+    $attachment_id = intval( $attachment_id );
+
+    if ( $attachment_id ) {
+        $thumb_url = wp_get_attachment_image_src( $attachment_id, 'thumbnail', true );
+        if ( $thumb_url ) {
+            $thumb_url = $thumb_url[0];
+        }
     }
 
@@ -2754 +2769 @@
         $table_class = '';
     } else {
-        $view = $table_class = 'not-image';
+        $view        = 'not-image';
+        $table_class = $view;
     }
 
@@ -2837 +2853 @@
     $browser_uploader = admin_url( 'media-new.php?browser-uploader' );
 
-    if ( $post = get_post() ) {
+    $post = get_post();
+    if ( $post ) {
         $browser_uploader .= '&amp;post_id=' . intval( $post->ID );
     } elseif ( ! empty( $GLOBALS['post_ID'] ) ) {
@@ -2877 +2894 @@
 function media_upload_max_image_resize() {
     $checked = get_user_setting( 'upload_resize' ) ? ' checked="true"' : '';
-    $a       = $end = '';
+    $a       = '';
+    $end     = '';
 
     if ( current_user_can( 'manage_options' ) ) {
@@ -2920 +2938 @@
     }
 
-    $thumb_url = false;
-    if ( $attachment_id = intval( $post->ID ) ) {
+    $thumb_url     = false;
+    $attachment_id = intval( $post->ID );
+    if ( $attachment_id ) {
         $thumb_url = wp_get_attachment_image_src( $attachment_id, array( 900, 450 ), true );
     }
@@ -2938 +2957 @@
         }
 
-        $open_style = $not_open_style = '';
+        $open_style     = '';
+        $not_open_style = '';
         if ( $open ) {
             $open_style = ' style="display:none"';
@@ -3512 +3532 @@
     if ( isset( $result ) ) {
         $location = 'upload.php';
-        if ( $referer = wp_get_referer() ) {
+        $referer  = wp_get_referer();
+        if ( $referer ) {
             if ( false !== strpos( $referer, 'upload.php' ) ) {
                 $location = remove_query_arg( array( 'attached', 'detach' ), $referer );