Changeset 49994

Timestamp:

01/21/2021 12:15:47 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Twenty Twenty-One: Consistently use Yoda condition for display_title_and_tagline setting.

Props mukesh27.
Fixes #52329.

Location:

trunk/src/wp-content/themes/twentytwentyone/template-parts/header

Files:

• site-branding.php (modified) (1 diff)
• site-header.php (modified) (1 diff)

trunk/src/wp-content/themes/twentytwentyone/template-parts/header/site-branding.php

@@ -35 +35 @@
     <?php endif; ?>
 
-    <?php if ( $description && get_theme_mod( 'display_title_and_tagline', true ) === true ) : ?>
+    <?php if ( $description && true === get_theme_mod( 'display_title_and_tagline', true ) ) : ?>
         <p class="site-description">
             <?php echo $description; // phpcs:ignore WordPress.Security.EscapeOutput ?>

trunk/src/wp-content/themes/twentytwentyone/template-parts/header/site-header.php

@@ -10 +10 @@
 $wrapper_classes  = 'site-header';
 $wrapper_classes .= has_custom_logo() ? ' has-logo' : '';
-$wrapper_classes .= true === get_theme_mod( 'display_title_and_tagline', true ) ? ' has-title-and-tagline' : '';
+$wrapper_classes .= ( true === get_theme_mod( 'display_title_and_tagline', true ) ) ? ' has-title-and-tagline' : '';
 $wrapper_classes .= has_nav_menu( 'primary' ) ? ' has-menu' : '';
 ?>