WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#52329 closed defect (bug) (fixed)

Twenty Twenty-One: Use Yoda condition

Reported by: mukesh27's profile mukesh27 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.6
Component: Bundled Theme Keywords: has-patch
Focuses: coding-standards Cc:

Description

Use Yoda condition in ​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwentyone/template-parts/header/site-branding.php#L37 as per best prectice documentation - ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions

Change History (4)

This ticket was mentioned in ​PR #883 on ​WordPress/wordpress-develop by ​mukeshpanchal27.
4 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/52329

#2 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.7

#3 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49994:

Twenty Twenty-One: Consistently use Yoda condition for display_title_and_tagline setting.

Props mukesh27.
Fixes #52329.

Note: See TracTickets for help on using tickets.