WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#52329 closed defect (bug) (fixed)

Twenty Twenty-One: Use Yoda condition

Reported by: mukesh27 Owned by: SergeyBiryukov
Priority: normal Milestone: 5.7
Component: Bundled Theme Version: 5.6
Severity: normal Keywords: has-patch
Cc: Focuses: coding-standards

Description

Use Yoda condition in ​https://github.com/WordPress/WordPress/blob/master/wp-content/themes/twentytwentyone/template-parts/header/site-branding.php#L37 as per best prectice documentation - ​https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions

Change History (4)

This ticket was mentioned in ​PR #883 on ​WordPress/wordpress-develop by ​mukeshpanchal27.
6 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/52329

#2 @SergeyBiryukov
6 years ago

  • Milestone Awaiting Review → 5.7

#3 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 49994:

Twenty Twenty-One: Consistently use Yoda condition for display_title_and_tagline setting.

Props mukesh27.
Fixes #52329.

Note: See TracTickets for help on using tickets.