Changeset 50981 for trunk/src/wp-admin/my-sites.php

Timestamp:

05/24/2021 07:58:13 PM (4 years ago)

Author:

desrosj

Message:

General: Avoid unnecessary calls to update_user_option().

The update_user_option() function is a way to update a user meta value after adding a blog’s prefix to the beginning of the meta key. But when the fourth parameter is true, the behavior is exactly the same as calling update_user_meta() directly.

This replaces all instances of update_user_option() when the fourth parameter is true in Core with a direct call to update_user_meta() to prevent an unnecessary call to update_user_option().

Props johnjamesjacoby, zkancs, obenland, desrosj.
Fixes #43339.

File:

• trunk/src/wp-admin/my-sites.php (modified) (1 diff)

trunk/src/wp-admin/my-sites.php

@@ -28 +28 @@
     $blog = get_site( (int) $_POST['primary_blog'] );
     if ( $blog && isset( $blog->domain ) ) {
-        update_user_option( $current_user->ID, 'primary_blog', (int) $_POST['primary_blog'], true );
+        update_user_meta( $current_user->ID, 'primary_blog', (int) $_POST['primary_blog'] );
         $updated = true;
     } else {