Global user_options calls should use user_meta instead

[johnjamesjacoby]

There are 2 places where WordPress uses the user_option functions with the global flag set to true which internally invokes the user_meta functions.

In these cases, there is no benefit to using user_option and only a detriment by way of additional function calls.

The user-meta keys in question are:

• default_password_nag
• community-events-location

[zkancs]

Use update_user_meta instead of update_user_option

[obenland]

It looks like there are some more instances where update_user_option is used with $global set to true. Doe we want to change those too?

[zkancs]

@obenland Yes, I'll change the rest of them.

[zkancs]

There're some mistakes in the HTML I've made. Fixing them.

[zkancs]

@obenland Fixed. I think I've changed every place where update_user_option is used with $global set to true. Please review again.

[pento]

43339.4.diff​ needs updating to apply to trunk.

Trac ticket: https://core.trac.wordpress.org/ticket/43339

[desrosj]

In 50981:

General: Avoid unnecessary calls to update_user_option().

The update_user_option() function is a way to update a user meta value after adding a blog’s prefix to the beginning of the meta key. But when the fourth parameter is true, the behavior is exactly the same as calling update_user_meta() directly.

This replaces all instances of update_user_option() when the fourth parameter is true in Core with a direct call to update_user_meta() to prevent an unnecessary call to update_user_option().

Props johnjamesjacoby, zkancs, obenland, desrosj.
Fixes #43339.

Merged into Core in https://core.trac.wordpress.org/changeset/50981.