Changeset 53842

Timestamp:

08/05/2022 01:37:47 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Revisions: Use wp_get_latest_revision_id_and_total_count() where appropriate.

The function executes an optimized query to get the last revision ID and total count. It was originally introduced for WP_REST_Posts_Controller::prepare_links(), and is now used in a few more places in core:

• register_and_do_post_meta_boxes()
• wp_get_post_revisions_url()
• wp_update_custom_css_post()

Follow-up to [53759], [53769], [53778], [53779], [53841].

Props peterwilsoncc, mukesh27, SergeyBiryukov.
Fixes #56279.

Location:

trunk/src

Files:

• wp-admin/includes/meta-boxes.php (modified) (1 diff)
• wp-includes/revision.php (modified) (1 diff)
• wp-includes/theme.php (modified) (1 diff)

trunk/src/wp-admin/includes/meta-boxes.php

@@ -1460 +1460 @@
 
     if ( post_type_supports( $post_type, 'revisions' ) && 'auto-draft' !== $post->post_status ) {
-        $revisions = wp_get_post_revisions( $post->ID, array( 'fields' => 'ids' ) );
+        $revisions = wp_get_latest_revision_id_and_total_count( $post->ID );
 
         // We should aim to show the revisions meta box only when there are revisions.
-        if ( count( $revisions ) > 1 ) {
+        if ( ! is_wp_error( $revisions ) && $revisions['count'] > 1 ) {
             $publish_callback_args = array(
-                'revisions_count'        => count( $revisions ),
-                'revision_id'            => reset( $revisions ),
+                'revisions_count'        => $revisions['count'],
+                'revision_id'            => $revisions['latest_id'],
                 '__back_compat_meta_box' => true,
             );

trunk/src/wp-includes/revision.php

@@ -604 +604 @@
     }
 
-    $revisions = wp_get_post_revisions( $post->ID, array( 'posts_per_page' => 1 ) );
-
-    if ( 0 === count( $revisions ) ) {
+    $revisions = wp_get_latest_revision_id_and_total_count( $post->ID );
+
+    if ( is_wp_error( $revisions ) || 0 === $revisions['count'] ) {
         return null;
     }
 
-    $revision = reset( $revisions );
-    return get_edit_post_link( $revision );
+    return get_edit_post_link( $revisions['latest_id'] );
 }
 

trunk/src/wp-includes/theme.php

@@ -2069 +2069 @@
 
             // Trigger creation of a revision. This should be removed once #30854 is resolved.
-            if ( 0 === count( wp_get_post_revisions( $r ) ) ) {
+            $revisions = wp_get_latest_revision_id_and_total_count( $r );
+            if ( ! is_wp_error( $revisions ) && 0 === $revisions['count'] ) {
                 wp_save_post_revision( $r );
             }