Use wp_get_latest_revision_id_and_total_count() where appropriate

[SergeyBiryukov]

Background: #55857

A new function wp_get_latest_revision_id_and_total_count(), with an optimized query to get the last revision ID and total count, was introduced in [53759], [53769], and [53778].

As noted in comment:4:ticket:55857, there are a few other places in core that could use it.

[mukesh27]

One extra semicolon is added in the patch, file wp-includes\revision.php. Can you please remove it?

[peterwilsoncc]

I've reopened #55857 to rename the function to wp_get_latest_revision_id_and_total_count() so the function follows the conventional term used for getting latest posts, comments, etc.

Please hold of committing this change until the rename is complete.

[SergeyBiryukov]

Replying to peterwilsoncc:

I've reopened #55857 to rename the function to wp_get_latest_revision_id_and_total_count() so the function follows the conventional term used for getting latest posts, comments, etc.

Thanks! 56279.2.diff​ switches to "latest" and removes the extra semicolon from the previous patch.

There may be more instances where the function can be used, these are just the ones I found at a glance.

[SergeyBiryukov]

Refreshed after [53841]. Found one more place to use this in wp_update_custom_css_post().

[SergeyBiryukov]

In 53842:

Revisions: Use wp_get_latest_revision_id_and_total_count() where appropriate.

The function executes an optimized query to get the last revision ID and total count. It was originally introduced for WP_REST_Posts_Controller::prepare_links(), and is now used in a few more places in core:

• register_and_do_post_meta_boxes()
• wp_get_post_revisions_url()
• wp_update_custom_css_post()

Follow-up to [53759], [53769], [53778], [53779], [53841].

Props peterwilsoncc, mukesh27, SergeyBiryukov.
Fixes #56279.