Changeset 53936

Timestamp:

08/24/2022 01:18:31 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove dynamic properties in WP_Test_REST_Users_Controller.

Dynamic (non-explicitly declared) properties are deprecated as of PHP 8.2 and are expected to become a fatal error in PHP 9.0.

In these particular cases, individual tests set a couple of properties ($author_id, $post_id) that are never used outside of the context of the test in which they are created.

In other words: these should never have been properties, but should be local variables instead.

Follow-up to [38832], [53557], [53558], [53850], [53851], [53852], [53853], [53854], [53856], [53916], [53935].

Props jrf.
See #56033.

File:

• trunk/tests/phpunit/tests/rest-api/rest-users-controller.php (modified) (8 diffs)

trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -1110 +1110 @@
 
         public function test_get_item_published_author_post() {
-                $this->author_id = $this->factory->user->create(
+                $author_id = $this->factory->user->create(
                         array(
                                 'role' => 'author',
@@ -1116 +1116 @@
                 );
 
-                $this->post_id = $this->factory->post->create(
-                        array(
-                                'post_author' => $this->author_id,
+                $post_id = $this->factory->post->create(
+                        array(
+                                'post_author' => $author_id,
                         )
                 );
@@ -1124 +1124 @@
                 wp_set_current_user( 0 );
 
-                $request  = new WP_REST_Request( 'GET', sprintf( '/wp/v2/users/%d', $this->author_id ) );
+                $request  = new WP_REST_Request( 'GET', sprintf( '/wp/v2/users/%d', $author_id ) );
                 $response = rest_get_server()->dispatch( $request );
                 $this->check_get_user_response( $response, 'embed' );
@@ -1130 +1130 @@
 
         public function test_get_item_published_author_pages() {
-                $this->author_id = $this->factory->user->create(
+                $author_id = $this->factory->user->create(
                         array(
                                 'role' => 'author',
@@ -1138 +1138 @@
                 wp_set_current_user( 0 );
 
-                $request  = new WP_REST_Request( 'GET', sprintf( '/wp/v2/users/%d', $this->author_id ) );
+                $request  = new WP_REST_Request( 'GET', sprintf( '/wp/v2/users/%d', $author_id ) );
                 $response = rest_get_server()->dispatch( $request );
                 $this->assertSame( 401, $response->get_status() );
 
-                $this->post_id = $this->factory->post->create(
-                        array(
-                                'post_author' => $this->author_id,
+                $post_id = $this->factory->post->create(
+                        array(
+                                'post_author' => $author_id,
                                 'post_type'   => 'page',
                         )
@@ -1165 +1165 @@
 
         public function test_get_item_published_author_wrong_context() {
-                $this->author_id = $this->factory->user->create(
+                $author_id = $this->factory->user->create(
                         array(
                                 'role' => 'author',
@@ -1171 +1171 @@
                 );
 
-                $this->post_id = $this->factory->post->create(
-                        array(
-                                'post_author' => $this->author_id,
+                $post_id = $this->factory->post->create(
+                        array(
+                                'post_author' => $author_id,
                         )
                 );
@@ -1179 +1179 @@
                 wp_set_current_user( 0 );
 
-                $request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/users/%d', $this->author_id ) );
+                $request = new WP_REST_Request( 'GET', sprintf( '/wp/v2/users/%d', $author_id ) );
                 $request->set_param( 'context', 'edit' );
                 $response = rest_get_server()->dispatch( $request );