Make WordPress Core


Ignore:
Timestamp:
09/09/2022 08:14:43 AM (13 months ago)
Author:
audrasjb
Message:

Coding Standards: Clarify time units for various timeout or expiration values.

This changeset implements a clearer and more consistent timeout/duration/expiration format. It updates time durations used in various files, as per WordPress coding standards:

  • If the value can be represented as an integer (not a fractional) number of minutes (hours, etc.), use the appropriate constant (e.g.: MINUTE_IN_SECONDS) multiplied by that number.
  • Otherwise, keep the value as is and add a comment with the units for clarity.

Follow-up to [11823], [13177], [21996], [37747], [53714].

Props hztyfoon, audrasjb, arrasel403, krupalpanchal, GaryJ, SergeyBiryukov, peterwilsoncc, rudlinkon, costdev, robinwpdeveloper.
Fixes #56293.
See #55647.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/file.php

    r53714 r54113  
    540540
    541541        // Make sure PHP process doesn't die before loopback requests complete.
    542         set_time_limit( 300 );
     542        set_time_limit( 5 * MINUTE_IN_SECONDS );
    543543
    544544        // Time to wait for loopback requests to finish.
    545         $timeout = 100;
     545        $timeout = 100; // 100 seconds.
    546546
    547547        $needle_start = "###### wp_scraping_result_start:$scrape_key ######";
     
    20082008     */
    20092009    if ( ! defined( 'FS_CONNECT_TIMEOUT' ) ) {
    2010         define( 'FS_CONNECT_TIMEOUT', MINUTE_IN_SECONDS / 2 );
     2010        define( 'FS_CONNECT_TIMEOUT', 30 ); // 30 seconds.
    20112011    }
    20122012    if ( ! defined( 'FS_TIMEOUT' ) ) {
    2013         define( 'FS_TIMEOUT', MINUTE_IN_SECONDS / 2 );
     2013        define( 'FS_TIMEOUT', 30 ); // 30 seconds.
    20142014    }
    20152015
Note: See TracChangeset for help on using the changeset viewer.