Changeset 54113 for trunk/src/wp-admin/includes/file.php

Timestamp:

09/09/2022 08:14:43 AM (4 years ago)

Author:

audrasjb

Message:

Coding Standards: Clarify time units for various timeout or expiration values.

This changeset implements a clearer and more consistent timeout/duration/expiration format. It updates time durations used in various files, as per WordPress coding standards:

• If the value can be represented as an integer (not a fractional) number of minutes (hours, etc.), use the appropriate constant (e.g.: MINUTE_IN_SECONDS) multiplied by that number.
• Otherwise, keep the value as is and add a comment with the units for clarity.

Follow-up to [11823], [13177], [21996], [37747], [53714].

Props hztyfoon, audrasjb, arrasel403, krupalpanchal, GaryJ, SergeyBiryukov, peterwilsoncc, rudlinkon, costdev, robinwpdeveloper.
Fixes #56293.
See #55647.

File:

• trunk/src/wp-admin/includes/file.php (modified) (2 diffs)

trunk/src/wp-admin/includes/file.php

@@ -540 +540 @@
 
                 // Make sure PHP process doesn't die before loopback requests complete.
-                set_time_limit( 300 );
+                set_time_limit( 5 * MINUTE_IN_SECONDS );
 
                 // Time to wait for loopback requests to finish.
-                $timeout = 100;
+                $timeout = 100; // 100 seconds.
 
                 $needle_start = "###### wp_scraping_result_start:$scrape_key ######";
@@ -2008 +2008 @@
          */
         if ( ! defined( 'FS_CONNECT_TIMEOUT' ) ) {
-                define( 'FS_CONNECT_TIMEOUT', MINUTE_IN_SECONDS / 2 );
+                define( 'FS_CONNECT_TIMEOUT', 30 ); // 30 seconds.
         }
         if ( ! defined( 'FS_TIMEOUT' ) ) {
-                define( 'FS_TIMEOUT', MINUTE_IN_SECONDS / 2 );
+                define( 'FS_TIMEOUT', 30 ); // 30 seconds.
         }