WordPress.org
Get WordPress

Make WordPress Core

Changeset 55528


Ignore:
Timestamp:
03/10/2023 04:28:49 PM (18 months ago)
Author:
desrosj
Message:

Build/Test Tools: Backport updates to GitHub Actions.

This backports several changesets to GitHub Actions workflows. These changesets:

  • address the deprecated notices related to save-output and set-output to ensure the workflows continue to run after these are removed.
  • adds support for automatically retrying a failed workflow once.
  • removes workflow files that are not applicable to the branch.
  • backports some Docker environment related tooling updates for the sake of consistency across branches.

Merges [53736], [53737], [53940], [53947], [54039], [54096], [54108], [54293], [54313], [54342], [54343], [54373], [54511], [54650], [54651], [54674], [54750], [54852], [55152], [54651], [55487] to the 4.8 branch.
See #55652, #56407, #56528, #54695, #56820, #56816, #56793, #56820, #57572.

Location:
branches/4.8
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • branches/4.8

  • branches/4.8/.env

    r50309 r55528  
    5858# Defaults to 5.7 with the assumption that LOCAL_DB_TYPE is set to `mysql` above.
    5959#
    60 # When using `mysql`, see https://hub.docker.com/_/mysql/ for valid versions.
    61 # When using `mariadb`, see https://hub.docker.com/_/mariadb for valid versions.
     60# When using `mysql`, see https://hub.docker.com/r/amd64/mysql for valid versions.
     61# When using `mariadb`, see https://hub.docker.com/r/amd64/mariadb for valid versions.
    6262##
    6363LOCAL_DB_VERSION=5.7

  • branches/4.8/.github/workflows/coding-standards.yml

    r53613 r55528  
    1010      - '[4-9].[0-9]'
    1111    tags:
    12       - '3.[89]*'
    13       - '[4-9].[0-9]*'
     12      - '[0-9]+.[0-9]'
     13      - '[0-9]+.[0-9].[0-9]+'
     14      - '!3.7.[0-9]+'
    1415  pull_request:
    1516    branches:
    … …  
    2122      - '**.js'
    2223      - '**.php'
    23       # These files configure NPM. Changes could affect the outcome.
     24      # These files configure npm. Changes could affect the outcome.
    2425      - 'package*.json'
    2526      # These files configure Composer. Changes could affect the outcome.
    … …  
    5051  # - Installs NodeJS.
    5152  # - Logs updated debug information.
    52   # _ Installs NPM dependencies.
     53  # _ Installs npm dependencies.
    5354  # - Run the WordPress JSHint checks.
    5455  jshint:
    … …  
    6263    steps:
    6364      - name: Checkout repository
    64         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
     65        uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    6566
    6667      - name: Log debug information
    … …  
    7172          svn --version
    7273
    73       - name: Install NodeJS
    74         uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     74      - name: Set up Node.js
     75        uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    7576        with:
    7677          node-version-file: '.nvmrc'
    … …  
    100101      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
    101102      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
     103
     104  failed-workflow:
     105    name: Failed workflow tasks
     106    runs-on: ubuntu-latest
     107    needs: [ jshint, slack-notifications ]
     108    if: |
     109      always() &&
     110      github.repository == 'WordPress/wordpress-develop' &&
     111      github.event_name != 'pull_request' &&
     112      github.run_attempt < 2 &&
     113      (
     114        needs.jshint.result == 'cancelled' || needs.jshint.result == 'failure'
     115      )
     116
     117    steps:
     118      - name: Dispatch workflow run
     119        uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 # v6.4.0
     120        with:
     121          retries: 2
     122          retry-exempt-status-codes: 418
     123          script: |
     124            github.rest.actions.createWorkflowDispatch({
     125              owner: context.repo.owner,
     126              repo: context.repo.repo,
     127              workflow_id: 'failed-workflow.yml',
     128              ref: 'trunk',
     129              inputs: {
     130                run_id: '${{ github.run_id }}'
     131              }
     132            });

  • branches/4.8/.github/workflows/javascript-tests.yml

    r53610 r55528  
    99      - '[4-9].[0-9]'
    1010    tags:
    11       - '3.[89]*'
    12       - '[4-9].[0-9]*'
     11      - '[0-9]+.[0-9]'
     12      - '[0-9]+.[0-9].[0-9]+'
     13      - '!3.7.[0-9]+'
    1314  pull_request:
    1415    branches:
    … …  
    1920      # Any change to a JavaScript file should run tests.
    2021      - '**.js'
    21       # These files configure NPM. Changes could affect the outcome.
     22      # These files configure npm. Changes could affect the outcome.
    2223      - 'package*.json'
    2324      # This file configures ESLint. Changes could affect the outcome.
    … …  
    4647  # - Installs NodeJS.
    4748  # - Logs updated debug information.
    48   # _ Installs NPM dependencies.
     49  # _ Installs npm dependencies.
    4950  # - Run the WordPress QUnit tests.
    5051  test-js:
    … …  
    5657    steps:
    5758      - name: Checkout repository
    58         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
     59        uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    5960
    6061      - name: Log debug information
    … …  
    6566          svn --version
    6667
    67       - name: Install NodeJS
    68         uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     68      - name: Set up Node.js
     69        uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    6970        with:
    7071          node-version-file: '.nvmrc'
    … …  
    9495      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
    9596      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
     97
     98  failed-workflow:
     99    name: Failed workflow tasks
     100    runs-on: ubuntu-latest
     101    needs: [ test-js, slack-notifications ]
     102    if: |
     103      always() &&
     104      github.repository == 'WordPress/wordpress-develop' &&
     105      github.event_name != 'pull_request' &&
     106      github.run_attempt < 2 &&
     107      (
     108        needs.test-js.result == 'cancelled' || needs.test-js.result == 'failure'
     109      )
     110
     111    steps:
     112      - name: Dispatch workflow run
     113        uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 # v6.4.0
     114        with:
     115          retries: 2
     116          retry-exempt-status-codes: 418
     117          script: |
     118            github.rest.actions.createWorkflowDispatch({
     119              owner: context.repo.owner,
     120              repo: context.repo.repo,
     121              workflow_id: 'failed-workflow.yml',
     122              ref: 'trunk',
     123              inputs: {
     124                run_id: '${{ github.run_id }}'
     125              }
     126            });

  • branches/4.8/.github/workflows/phpunit-tests.yml

    r53610 r55528  
    88      - '[4-9].[0-9]'
    99    tags:
    10       - '3.[7-9]*'
    11       - '[4-9].[0-9]*'
     10      - '[0-9]+.[0-9]'
     11      - '[0-9]+.[0-9].[0-9]+'
    1212  pull_request:
    1313    branches:
    … …  
    3131  PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: ${{ true }}
    3232  COMPOSER_INSTALL: ${{ false }}
    33   # Controls which NPM script to use for running PHPUnit tests. Options ar `php` and `php-composer`.
     33  # Controls which npm script to use for running PHPUnit tests. Options ar `php` and `php-composer`.
    3434  PHPUNIT_SCRIPT: php
    3535  LOCAL_PHP_MEMCACHED: ${{ false }}
    … …  
    4444  # - Logs debug information about the GitHub Action runner.
    4545  # - Installs NodeJS.
    46   # _ Installs NPM dependencies.
     46  # _ Installs npm dependencies.
    4747  # - Builds WordPress to run from the `build` directory.
    4848  # - Creates a ZIP file of compiled WordPress.
    … …  
    5555    steps:
    5656      - name: Checkout repository
    57         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
     57        uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    5858
    5959      - name: Log debug information
    … …  
    7070          locale -a
    7171
    72       - name: Install NodeJS
    73         uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     72      - name: Set up Node.js
     73        uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    7474        with:
    7575          node-version-file: '.nvmrc'
    … …  
    8383
    8484      - name: Create ZIP artifact
    85         uses: thedoctor0/zip-release@09336613be18a8208dfa66bd57efafd9e2685657 # v0.6.2
     85        uses: thedoctor0/zip-release@a24011d8d445e4da5935a7e73c1f98e22a439464 # v0.7.1
    8686        with:
    8787          filename: built-wp-${{ github.sha }}.zip
    … …  
    8989
    9090      - name: Upload build artifact
    91         uses: actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8 # v3.1.0
     91        uses: actions/upload-artifact@0b7f8abb1508181956e8e162db84b466c27e18ce # v3.1.2
    9292        with:
    9393          name: built-wp-${{ github.sha }}
    … …  
    103103  # - Unzips the artifact.
    104104  # - Installs NodeJS.
    105   # _ Installs NPM dependencies.
     105  # _ Installs npm dependencies.
    106106  # - Configures caching for Composer.
    107107  # _ Installs Composer dependencies (if desired).
    … …  
    203203
    204204      - name: Download the built WordPress artifact
    205         uses: actions/download-artifact@fb598a63ae348fa914e94cd0ff38f362e927b741 # v3.0.0
     205        uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
    206206        with:
    207207          name: built-wp-${{ github.sha }}
    … …  
    210210        run: unzip built-wp-${{ github.sha }}.zip
    211211
    212       - name: Install NodeJS
    213         uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     212      - name: Set up Node.js
     213        uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    214214        with:
    215215          node-version-file: '.nvmrc'
    … …  
    221221      - name: Cache Composer dependencies
    222222        if: ${{ env.COMPOSER_INSTALL == true }}
    223         uses: actions/cache@c3f1317a9e7b1ef106c153ac8c0f00fed3ddbc0d # v3.0.4
     223        uses: actions/cache@69d9d449aced6a2ede0bc19182fadc3a0a42d2b0 # v3.2.6
    224224        env:
    225225          cache-name: cache-composer-dependencies
    … …  
    302302      - name: Checkout the WordPress Test Reporter
    303303        if: ${{ github.repository == 'WordPress/wordpress-develop' && github.ref == 'refs/heads/trunk' && matrix.report }}
    304         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
     304        uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    305305        with:
    306306          repository: 'WordPress/phpunit-test-runner'
    … …  
    333333      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
    334334      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
     335
     336  failed-workflow:
     337    name: Failed workflow tasks
     338    runs-on: ubuntu-latest
     339    needs: [ test-php, slack-notifications ]
     340    if: |
     341      always() &&
     342      github.repository == 'WordPress/wordpress-develop' &&
     343      github.event_name != 'pull_request' &&
     344      github.run_attempt < 2 &&
     345      (
     346        needs.test-php.result == 'cancelled' || needs.test-php.result == 'failure'
     347      )
     348
     349    steps:
     350      - name: Dispatch workflow run
     351        uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 # v6.4.0
     352        with:
     353          retries: 2
     354          retry-exempt-status-codes: 418
     355          script: |
     356            github.rest.actions.createWorkflowDispatch({
     357              owner: context.repo.owner,
     358              repo: context.repo.repo,
     359              workflow_id: 'failed-workflow.yml',
     360              ref: 'trunk',
     361              inputs: {
     362                run_id: '${{ github.run_id }}'
     363              }
     364            });

  • branches/4.8/.github/workflows/test-npm.yml

    r53610 r55528  
    1 name: Test NPM
     1name: Test npm
    22
    33on:
    … …  
    77      - '3.[7-9]'
    88      - '[4-9].[0-9]'
     9    tags:
     10      - '[0-9]+.[0-9]'
     11      - '[0-9]+.[0-9].[0-9]+'
    912  pull_request:
    1013    branches:
    … …  
    1316      - '[4-9].[0-9]'
    1417    paths:
    15       # These files configure NPM. Changes could affect the outcome.
     18      # These files configure npm. Changes could affect the outcome.
    1619      - 'package*.json'
    17       # JavaScript files are built using NPM.
     20      # JavaScript files are built using npm.
    1821      - '**.js'
    19       # CSS and SCSS files are built using NPM.
     22      # CSS and SCSS files are built using npm.
    2023      - '**.scss'
    2124      - '**.css'
    … …  
    3538
    3639jobs:
    37   # Verifies that installing NPM dependencies and building WordPress works as expected.
     40  # Verifies that installing npm dependencies and building WordPress works as expected.
    3841  #
    3942  # Performs the following steps:
    … …  
    4144  # - Logs debug information about the GitHub Action runner.
    4245  # - Installs NodeJS.
    43   # _ Installs NPM dependencies.
     46  # _ Installs npm dependencies.
    4447  # - Builds WordPress to run from the `build` directory.
    4548  # - Cleans up after building WordPress to the `build` directory.
    … …  
    4750  # - Cleans up after building WordPress to the `src` directory.
    4851  test-npm:
    49     name: Test NPM on ${{ matrix.os }}
     52    name: Test npm on ${{ matrix.os }}
    5053    runs-on: ${{ matrix.os }}
    5154    timeout-minutes: 20
    … …  
    5861    steps:
    5962      - name: Checkout repository
    60         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
     63        uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    6164
    6265      - name: Log debug information
    … …  
    6871          svn --version
    6972
    70       - name: Install NodeJS
    71         uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     73      - name: Set up Node.js
     74        uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    7275        with:
    7376          node-version-file: '.nvmrc'
    … …  
    8992        run: npm run grunt clean -- --dev
    9093
    91   # Verifies that installing NPM dependencies and building WordPress works as expected on MacOS.
     94  # Verifies that installing npm dependencies and building WordPress works as expected on MacOS.
    9295  #
    9396  # This is separate from the job above in order to use stricter conditions about when to run.
    9497  # This avoids unintentionally consuming excessive minutes, as MacOS jobs consume minutes at a 10x rate.
     98  #
     99  # The `matrix` and `runner` contexts are not available for use within `if` expressions. So there is
     100  # currently no way to determine the OS being used on a given job.
     101  # See https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability.
    95102  #
    96103  # Performs the following steps:
    … …  
    98105  # - Logs debug information about the GitHub Action runner.
    99106  # - Installs NodeJS.
    100   # _ Installs NPM dependencies.
     107  # _ Installs npm dependencies.
    101108  # - Builds WordPress to run from the `build` directory.
    102109  # - Cleans up after building WordPress to the `build` directory.
    … …  
    104111  # - Cleans up after building WordPress to the `src` directory.
    105112  test-npm-macos:
    106     name: Test NPM on MacOS
     113    name: Test npm on MacOS
    107114    runs-on: macos-latest
     115    timeout-minutes: 30
    108116    if: ${{ github.repository == 'WordPress/wordpress-develop' }}
    109117    steps:
    110118      - name: Checkout repository
    111         uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b # v3.0.2
     119        uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3.3.0
    112120
    113121      - name: Log debug information
    … …  
    119127          svn --version
    120128
    121       - name: Install NodeJS
    122         uses: actions/setup-node@eeb10cff27034e7acf239c5d29f62154018672fd # v3.3.0
     129      - name: Set up Node.js
     130        uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c # v3.6.0
    123131        with:
    124132          node-version-file: '.nvmrc'
    … …  
    152160      SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
    153161      SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}
     162
     163  failed-workflow:
     164    name: Failed workflow tasks
     165    runs-on: ubuntu-latest
     166    needs: [ test-npm, test-npm-macos, slack-notifications ]
     167    if: |
     168      always() &&
     169      github.repository == 'WordPress/wordpress-develop' &&
     170      github.event_name != 'pull_request' &&
     171      github.run_attempt < 2 &&
     172      (
     173        needs.test-npm.result == 'cancelled' || needs.test-npm.result == 'failure' ||
     174        needs.test-npm-macos.result == 'cancelled' || needs.test-npm-macos.result == 'failure'
     175      )
     176
     177    steps:
     178      - name: Dispatch workflow run
     179        uses: actions/github-script@98814c53be79b1d30f795b907e553d8679345975 # v6.4.0
     180        with:
     181          retries: 2
     182          retry-exempt-status-codes: 418
     183          script: |
     184            github.rest.actions.createWorkflowDispatch({
     185              owner: context.repo.owner,
     186              repo: context.repo.repo,
     187              workflow_id: 'failed-workflow.yml',
     188              ref: 'trunk',
     189              inputs: {
     190                run_id: '${{ github.run_id }}'
     191              }
     192            });

  • branches/4.8/.github/workflows/welcome-new-contributors.yml

    r53610 r55528  
    1313
    1414    steps:
    15       - uses: bubkoo/welcome-action@8dbbac2540d155744c90e4e37da6b05ffc9c5e2c # v1.0.3
     15      - uses: wow-actions/welcome@72817eb31cda1de60f51893d80e2e82ce57f7e76 # v1.3.0
    1616        with:
    17           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    1817          FIRST_PR_COMMENT: >
    1918            Hi @{{ author }}! 👋

  • branches/4.8/docker-compose.yml

    r50309 r55528  
    5454  ##
    5555  mysql:
    56     image: ${LOCAL_DB_TYPE-mysql}:${LOCAL_DB_VERSION-5.7}
     56    image: amd64/${LOCAL_DB_TYPE-mysql}:${LOCAL_DB_VERSION-5.7}
    5757
    5858    networks:
Note: See TracChangeset for help on using the changeset viewer.