#56820 closed task (blessed) (fixed)
Remove use of save-state and set-output in GitHub Actions
Reported by: | desrosj | Owned by: | desrosj |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch commit dev-reviewed |
Focuses: | Cc: |
Description
The save-state
and set-output
commands have been deprecated in GitHub Actions and a large number of notices are being shown on workflow runs.
Some of these are coming from third-party actions and cannot be fixed until an update is made available. However, there are a handful within steps specific to Core that should also be fixed.
Change History (34)
#2
@
2 years ago
- Milestone changed from 6.2 to 6.1
- Type changed from defect (bug) to task (blessed)
Prior to [54511] there were 344 related total warnings being output across Core's workflows.
After, this is reduced to 74. Going to continue chunking through as updates become available.
#3
@
2 years ago
FYI: setup-php
has announced that a new version will be tagged, probably this weekend, which will fix it for that action runner. See: https://github.com/shivammathur/setup-php/issues/654
This ticket was mentioned in PR #3486 on WordPress/wordpress-develop by @desrosj.
2 years ago
#4
- Keywords has-patch added
Trac ticket: https://core.trac.wordpress.org/ticket/56820.
This ticket was mentioned in Slack in #core by chaion07. View the logs.
2 years ago
#6
@
2 years ago
Thanks @desrosj for reporting this. We discussed this ticket during a recent bug-scrub session. Here's the summary of the feedback received from the team.
- This is just a tooling item to address the deprecated items upstream.
- @desrosj graciously volunteered to take care sometime in the near future with a new patch to commit.
- The team decided to leave the ticket as is and in the milestone.
Props to @desrosj for all the hard work!
#9
@
2 years ago
- Keywords commit dev-feedback added
It's going to take a bit more time for third-party actions to update and remove these. All of the instances of this have been removed from the Core workflow code, so I think this can be closed out after [54649] is backported and those can be taken care of as they become available.
Marking for a second committer to review.
Also, #56882 can handle any further backporting.
#10
follow-up:
↓ 11
@
2 years ago
Marking for a second committer to review.
What needs to be reviewed ? Commit [54649] for backport ? If so, I'm good with it.
In 54511: