WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#56882 closed task (blessed) (fixed)

Backport several GitHub Action compatibility fixes

Reported by: desrosj's profile desrosj Owned by: desrosj's profile desrosj
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description

There are several changes on the GitHub Action platform that need to be backported to older branches to ensure workflows continue to run.

These changes address the following from upstream:

  • Node.js 12 has been deprecated on GHA runners and will be removed in 2023 (see ​upstream blog post).
  • set-output and save-state have been deprecated. Starting 1st June 2023 workflows using these commands will fail (see ​upstream blog post).

While in some cases, these are not in use in Core workflow YML files, third party actions utilize these and need to be updated.

Related: #56820.

Change History (51)

This ticket was mentioned in ​PR #3511 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #1

  • Keywords has-patch added

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #3512 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #2

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #3513 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #3

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #3514 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #4

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

#5 @desrosj
2 years ago

#56795 was marked as a duplicate.

#6 @desrosj
2 years ago

In 54750:

Build/Test Tools: Fix more set-output deprecated warnings.

This updates the ramsey/composer-install and shivammathur/setup-php actions to their latest versions.

These updates include fixes for the deprecated warnings output when using set-output and save-state commands.

Props jrf, desrosj.
See #56820, #56882, #56793.

#7 @desrosj
2 years ago

In 55357:

Build/Test Tools: Backport updates to GitHub Actions.

This backports updates to GitHub Actions workflows required to address deprecated notices related to save-output and set-output.

Merges [54650], [54750], [54851], [54852], [54856], and [55152] to the 6.1 branch.
See #56882, #56820.

This ticket was mentioned in ​Slack in #core by costdev. ​View the logs.
2 years ago

This ticket was mentioned in ​Slack in #core by mukeshpanchal27. ​View the logs.
2 years ago

This ticket was mentioned in ​PR #4183 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #11

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4186 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #13

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4187 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #14

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4188 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #15

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4189 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #16

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4190 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #17

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4191 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #18

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4192 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #19

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4193 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #20

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4194 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #21

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4195 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #22

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4196 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #23

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4197 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #24

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4198 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #25

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4199 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #26

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4200 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #27

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

This ticket was mentioned in ​PR #4201 on ​WordPress/wordpress-develop by ​@desrosj.
2 years ago #28

This backports some workflow changes to prevent them from breaking in the future due to changes by GitHub upstream.

Trac ticket: https://core.trac.wordpress.org/ticket/56882.

#29 @costdev
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Per the discussion in the bug scrub, as we're about to enter RC, closing this ticket out for 6.2.

#30 @desrosj
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening because there's still backports from 4.1-5.9 remaining. They are ready to go in the PRs attached, but I did not want to commit them today with RC1 going out.

Build/Test Tool changes can be committed at any point during the release cycle (when appropriate). The remaining changes will not affect what gets generated and shipped as 6.2 at all, so this one is fine to leave open. I appreciate trying to clear the milestone, but please leave this open for now. I'll have it wrapped up in the next 24 hours.

#31 @desrosj
2 years ago

  • Keywords commit added

#51 @desrosj
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

This one is good to go!

Note: See TracTickets for help on using tickets.