Changeset 55907

Timestamp:

06/12/2023 11:20:58 AM (16 months ago)

Author:

spacedmonkey

Message:

Editor: Improve the append_to_selector method.

Improve append_to_selector method in WP_Theme_JSON by checking to see if string contains a common before imploding / exploding string, which improves performance.

Originally developed and tested in [WordPress/gutenberg#47833 Gutenberg PR 47833].

Props spacedmonkey, flixos90, mukesh27, joemcgill, wildworks, oandregal, mamaduka.
Fixes #58231.

File:

• trunk/src/wp-includes/class-wp-theme-json.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-theme-json.php

@@ -790 +790 @@
      */
     protected static function append_to_selector( $selector, $to_append, $position = 'right' ) {
+        if ( ! str_contains( $selector, ',' ) ) {
+            return 'right' === $position ? $selector . $to_append : $to_append . $selector;
+        }
         $new_selectors = array();
         $selectors     = explode( ',', $selector );