Make WordPress Core

Opened 12 months ago

Closed 11 months ago

Last modified 10 months ago

#58231 closed enhancement (fixed)

Improvements on append_to_selector method

Reported by: spacedmonkey's profile spacedmonkey Owned by: spacedmonkey's profile spacedmonkey
Milestone: 6.3 Priority: normal
Severity: normal Version:
Component: Editor Keywords: gutenberg-merge has-patch
Focuses: performance Cc:

Change History (12)

This ticket was mentioned in PR #4412 on WordPress/wordpress-develop by @spacedmonkey.


12 months ago
#1

  • Keywords has-patch added

#2 @spacedmonkey
12 months ago

Ping @hellofromTonya

This ticket was mentioned in Slack in #core-editor by spacedmonkey. View the logs.


12 months ago

#4 @flixos90
12 months ago

Related: #58193

Maybe we should add that to Gutenberg first and then backport. See https://github.com/WordPress/wordpress-develop/pull/4380#issuecomment-1522910737

@oandregal commented on PR #4412:


12 months ago
#5

I see this backports https://github.com/WordPress/gutenberg/pull/47833 and https://github.com/WordPress/gutenberg/pull/48759 Noting so we don't forget linking this to the original gutenberg PRs and the props to t-hamano.

I also see that there is a related ticket https://core.trac.wordpress.org/ticket/58193 and that Felix mentioned he'll work on backporting everything https://github.com/WordPress/gutenberg/pull/47833#issuecomment-1532196824

Changes seem fine to me, though.

@oandregal commented on PR #4412:


12 months ago
#6

There is no process for backports, it changes from person to person. I can share what I do when I backport and what I find helpful:

Not that this is mandatory in any way, though I've found it very helpful.

#7 @mukesh27
11 months ago

  • Owner set to spacedmonkey
  • Status changed from new to assigned

This ticket was discussed in the recent Performance bug scrub.

This is a backport that was missed from the Gutenberg repo. I think it's likely good to commit, but probably should get a code review on the PR.

Additional props to @joemcgill

#8 @spacedmonkey
11 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 55907:

Editor: Improve the append_to_selector method.

Improve append_to_selector method in WP_Theme_JSON by checking to see if string contains a common before imploding / exploding string, which improves performance.

Originally developed and tested in [WordPress/gutenberg#47833 Gutenberg PR 47833].

Props spacedmonkey, flixos90, mukesh27, joemcgill, wildworks, oandregal, mamaduka.
Fixes #58231.

@isabel_brison commented on PR #4412:


10 months ago
#9

Hi! To confirm, this is meant to be a separate piece from #4380?

I added this PR to the 6.3 board, please feel free to move it to "needs core commit" if it's good to go!

@spacedmonkey commented on PR #4412:


10 months ago
#11

Hi! To confirm, this is meant to be a separate piece from #4380?

I added this PR to the 6.3 board, please feel free to move it to "needs core commit" if it's good to go!

@tellthemachines I committed as I wanted to unblock my ticket. Let's backport that separately.

@isabel_brison commented on PR #4412:


10 months ago
#12

Thanks @spacedmonkey !

Note: See TracTickets for help on using tickets.