XMLRPC wp.getComments 'spam' status returned as 'hold'

[nigelgos]

When requesting spam messages the status is returned as 'hold'. This means you can't differentiate between comment statuses when you ask for 'spam' and 'hold' comments to be returned.

It does return the correct comments, just the status is wrong.

[josephscott]

I'm able to reproduce this.

After looking through the path for the comment status it turns out that it is the value comparison checking in the wp_getComment function that was causing the confusion:

        if ( 0 == $comment->comment_approved )
            $comment_status = 'hold';
        else if ( 'spam' == $comment->comment_approved )
            $comment_status = 'spam';
        else if ( 1 == $comment->comment_approved )
            $comment_status = 'approve';
        else
            $comment_status = $comment->comment_approved;

The comment approved field is a string. This was tripping up comments with 'spam' status and indicating that there were 'hold'. By quoting the numeric comparisons for the zero and one values the conditional checks work as expected. After making this change my tests show that the XML-RPC method wp.getComment (and wp.getComments) return the correct status values of hold, approve and spam.

I've attached a diff to make this change.

[westi]

(In [11783]) Ensure that XMLRPC clients can tell the difference between unapproved and spam comments. Fixes #10510 props josephscott.