wp_count_comments() should be cached in a transient.

[Denis-de-Bernardy]

wp_count_comments() gets called on every admin page. It's not a super expensive on, but it probably belongs in a transient that gets updated whenever the number of pending comment changes.

[hakre]

Nice find, this is for the menu. Maybe we should cache the number of plugins as well or isn't that already chached, right?

[Denis-de-Bernardy]

if you're meaning plugin updates, those are already cached.

[chrisscott]

Patch attached against r13330 to change wp_cache_get/set to transient.

[nacin]

We'd also need to update/clear the transient whenever the number of pending comments changes.

[chrisscott]

Replying to nacin:

We'd also need to update/clear the transient whenever the number of pending comments changes.

Sorry, I thought about that and then forgot just as quickly...

This is a little more complex than just pending comment change since the object stored in the transient has counts for total_comments, approved, moderated, spam, trash and post-trash statuses. Not sure how to proceed w/this.

[nacin]

Replying to chrisscott:

Replying to nacin:

We'd also need to update/clear the transient whenever the number of pending comments changes.

This is a little more complex than just pending comment change since the object stored in the transient has counts for total_comments, approved, moderated, spam, trash and post-trash statuses. Not sure how to proceed w/this.

We can bust the transient during a comment status change.

[Denis-de-Bernardy]

per discussion on IRC, it's not persistently cached because on sites that get loads of comments, it gets invalidated all the time.