WordPress.org

Make WordPress Core

Opened 8 years ago

Last modified 3 years ago

#11950 reopened enhancement

Sticky Posts are too aggressive

Reported by: prettyboymp Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 2.9.1
Component: Query Keywords: has-patch stickies
Focuses: Cc:

Description

I don't think the default behavior should be to have sticky posts included every time a query_posts() is used. I realize you can set the 'caller_get_posts' argument to avoid sticky posts from being added, however having to do this everywhere becomes a burden.

What are your thoughts on having the WP class add 'include_sticky' var to the_query if it isn't already set and then not include the sticky posts by default?

Attachments (1)

11950.diff (2.8 KB) - added by wonderboymusic 4 years ago.

Download all attachments as: .zip

Change History (18)

#1 @prettyboymp
8 years ago

  • Keywords dev-feedback added

#2 follow-up: @westi
7 years ago

You can now pass in ignore_sticky_posts

#3 in reply to: ↑ 2 @prettyboymp
7 years ago

Replying to westi:

You can now pass in ignore_sticky_posts

I understand there are options, but I still don't think that sticky posts should be included in every query call by default. They really only make sense to be included in the main loop, which could easily be added by an argument passed from the WP class, though I understand, we're fighting a backwards compatibility issue at this point.

#4 @jane
6 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

13 months with no comments indicates a lack of community interest/support for the ticket. Closing as wontfix. If re-opening, please include a patch.

#5 @nacin
6 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

I really like this idea. Patch is trivial — it comes down to whether we can get away with breaking this. westi, ryan?

#6 @nacin
6 years ago

  • Component changed from General to Query
  • Milestone set to Awaiting Review

@wonderboymusic
4 years ago

#7 @wonderboymusic
4 years ago

  • Keywords has-patch added; dev-feedback removed
  • Milestone changed from Awaiting Review to 3.7

11950.diff breathes some oxygen into this. I am not sure if where I set include_sticky query var in WP::parse_request is appropriate

Moving to 3.7 for discussion. @nacin endorsed this ticket 20 months ago.

#8 @wonderboymusic
4 years ago

#13365 was marked as a duplicate.

#9 @wonderboymusic
4 years ago

#14115 was marked as a duplicate.

#10 @azizur
4 years ago

  • Cc azizur added

#11 @wonderboymusic
4 years ago

#21687 was marked as a duplicate.

#12 @nacin
4 years ago

  • Milestone changed from 3.7 to Future Release

Pushing on this.

#13 @wonderboymusic
4 years ago

  • Keywords stickies added

This ticket was mentioned in IRC in #wordpress-dev by MadLems. View the logs.


3 years ago

This ticket was mentioned in Slack in #core-themes by philip. View the logs.


3 years ago

#16 @philiparthurmoore
3 years ago

  • Keywords changed from has-patch, stickies to has-patch stickies

Very big +1 to this. Post counts and layouts are fairly unpredictable at times due to stickies. This small addition would breathe some life into stickies and make things so much easier for predicting behavior.

#17 @philiparthurmoore
3 years ago

Just a note that those Keywords appear to have changed automatically.

Note: See TracTickets for help on using tickets.