WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#12237 closed defect (bug) (fixed)

Merge STYLE_DEBUG with SCRIPT_DEBUG

Reported by: nacin Owned by:
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Administration Keywords: dev-feedback has-patch
Focuses: Cc:

Description

Defining STYLE_DEBUG by itself does not serve concatenated development scripts, because both scripts and styles depend on the same concatenation global (and overriding CONCATENATE_SCRIPTS constant).

It will serve the development version of colors, but that's about it.

I suggest we get rid of STYLE_DEBUG and change all of its references to SCRIPT_DEBUG.

The alternative would be to allow concatenation to be controlled independently, but that would introduce another global and change existing behavior, having an effect outside of debugging. Removing STYLE_DEBUG has no real downside and makes it one less constant for developers to define.

Attachments (1)

12237.diff (1.7 KB) - added by nacin 4 years ago.

Download all attachments as: .zip

Change History (5)

nacin4 years ago

comment:1 nacin4 years ago

  • Keywords has-patch added
  • Milestone changed from Unassigned to 3.0

Likewise, because of the $concatenated_scripts bottleneck, setting only SCRIPT_DEBUG will unconcatenate styles, but leave them minified.

comment:2 nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [13183]) Remove STYLE_DEBUG constant, SCRIPT_DEBUG now handles both scripts and CSS. Fixes #12237

comment:3 matveb4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Shouldn't wp-admin/css/ms.dev.css be included when SCRIPT_DEBUG?

comment:4 nacin4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.