WordPress.org

Make WordPress Core

Opened 10 years ago

Last modified 5 months ago

#12363 assigned defect (bug)

Comment permalink wrong when only listing one comment type

Reported by: Viper007Bond Owned by: wonderboymusic
Milestone: Priority: normal
Severity: normal Version: 3.0
Component: Comments Keywords: needs-patch dev-feedback
Focuses: Cc:
PR Number:

Description

If you pass the type parameter to wp_list_comments() (for example, to show comments only and no pings), then comment permalinks can easily use the wrong page number as they expect there to be pings included. This is apparent after leaving a comment and WordPress attempts to redirect back to your new comment.

At first I was thinking you could tell WordPress that you're filtering to a type and it could compensate when determining the page number, but then I realized perhaps it'd just be better for wp_list_comments() to check if there were 0 comments returned for the query and if so, see if there are any of that type of comment available. If so, then we know we're on too high of a page number and can instead display the highest existing page. Then again this introduces SEO issues.

Ideas on what to do are welcome.

Change History (7)

#1 @hakre
9 years ago

  • Keywords dev-feedback added

#2 @nacin
9 years ago

  • Milestone changed from Awaiting Triage to Future Release

#3 @nacin
9 years ago

At first I was thinking you could tell WordPress that you're filtering to a type and it could compensate when determining the page number,

That does make sense.

#5 @wonderboymusic
4 years ago

  • Milestone changed from Future Release to 4.4
  • Owner set to wonderboymusic
  • Status changed from new to assigned

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 years ago

#7 @wonderboymusic
4 years ago

  • Milestone changed from 4.4 to Future Release

I don't have the patience for this one right now

Note: See TracTickets for help on using tickets.