Paged wp_list_comments() should always output something

[Viper007Bond]

Enable comment paging on your blog and visit http://yourblog.com/a/single/post/comment-page-999999/. Note no comments will be displayed.

There's situations where the comment form will redirect you back to the wrong page (for example if you mess with the type parameter and exclude pings). The Walker should detect if there's no comments to be displayed on the requested page and if that's the case, then display the latest page that actually has comments.

[edward mindreantre]

Fixed.

[chriscct7]

Seems to still be valid in 4.0

[chriscct7]

Patch is still good ( I misread it for a second there )

[couturefreak]

Displays last page of comments, and fixes the resulting comment pagination links.

[couturefreak]

Related #20319

[rachelbaker]

@couturefreak Thanks for the patch. Would you mind refreshing it without the extra formatting fixes?

[wonderboymusic]

This should be a fix in canonical

[wonderboymusic]

Related: #12363

[tyxla]

In redirect_canonical() redirect comment pages that are larger than the maximum comment page to the post itself.

[tyxla]

11248.2.patch fixes the issue as @wonderboymusic suggested.

Canonical unit test case included.

This will basically redirect the comment page links for pages that are larger than the maximum to the post link.
So for example if there is a maximum of 3 comment pages,

/comment-test/comment-page-4/

will redirect to

/comment-test/.

[boonebgorges]

Let's not pull up every single comment object belonging to a post to determine the page of comment. I recently wrote something that is a little more lightweight for determining the number of top-level comments on a post - see the top_level_count logic in [34729]. Maybe we can separate this out, and use it to determine the number of comment pages here.

[tyxla]

Updating the previous patch to use a more efficient way of getting the total comment pages (props @boonebgorges for the suggestion)

[tyxla]

Makes sense. I've updated the patch to use the solution @boonebgorges suggested for fetching the number of top level comments. This is used when calculating the total number of comment pages.

[boonebgorges]

I wrote a set of functions to do the number-of-pages calculation in https://core.trac.wordpress.org/attachment/ticket/8071/8071.8.diff. I'm going to wait to land that before taking care of the current ticket.