WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#12372 closed defect (bug) (fixed)

Remove Archaic get_children() reference returns

Reported by: filosofo Owned by: filosofo
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: General Keywords: has-patch
Focuses: Cc:

Description

It appears from r03321 that the children objects variable returned by get_children originally was meant to be bound by reference to the posts object cache.

However, currently get_children passes its objects to update_post_cache which in turn iterates over them not by reference with wp_cache_add. So the reference is no longer to the cache.

Besides, aside from the new twentyten theme, nowhere else in core does a variable get bound to that returned by get_children. So patch removes get_children's reference syntax.

Attachments (2)

remove_archaic_reference_returns.12372.diff (2.0 KB) - added by filosofo 4 years ago.
remove_archaic_reference_returns.12372.2.diff (821 bytes) - added by filosofo 3 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 miqrogroove4 years ago

  • Cc miqrogroove@… added

comment:2 nacin4 years ago

  • Milestone changed from 3.0 to 3.1

comment:3 filosofo4 years ago

  • Keywords get_children reference removed
  • Milestone changed from Awaiting Triage to 3.1
  • Owner changed from ryan to filosofo
  • Status changed from new to assigned

comment:4 filosofo3 years ago

Refreshed patch.

comment:5 scribu3 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [16667]) Remove archaic reference return in get_children(). Props filosofo. Fixes #12372

Note: See TracTickets for help on using tickets.