WordPress.org
Get WordPress

Make WordPress Core

Opened 16 years ago

Closed 16 years ago

#12372 closed defect (bug) (fixed)

Remove Archaic get_children() reference returns

Reported by: filosofo Owned by: filosofo
Priority: normal Milestone: 3.1
Component: General Version: 3.0
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

It appears from r03321 that the children objects variable returned by get_children originally was meant to be bound by reference to the posts object cache.

However, currently get_children passes its objects to update_post_cache which in turn iterates over them not by reference with wp_cache_add. So the reference is no longer to the cache.

Besides, aside from the new twentyten theme, nowhere else in core does a variable get bound to that returned by get_children. So patch removes get_children's reference syntax.

Attachments (2)

remove_archaic_reference_returns.12372.diff​ (2.0 KB ) - added by filosofo 16 years ago.
remove_archaic_reference_returns.12372.2.diff​ (821 bytes ) - added by filosofo 16 years ago.

Download all attachments as: .zip

Change History (7)

@filosofo
16 years ago

#1 @miqrogroove
16 years ago

  • Cc miqrogroove@… added

#2 @nacin
16 years ago

  • Milestone 3.0 → 3.1

#3 @filosofo
16 years ago

  • Keywords get_children reference removed
  • Milestone Awaiting Triage → 3.1
  • Owner changed from ryan to filosofo
  • Status new → assigned

@filosofo
16 years ago

#4 @filosofo
16 years ago

Refreshed patch.

#5 @scribu
16 years ago

  • Resolution → fixed
  • Status assigned → closed

(In [16667]) Remove archaic reference return in get_children(). Props filosofo. Fixes #12372

Note: See TracTickets for help on using tickets.