Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#12804 closed enhancement (fixed)

Make TwentyTen footer.php credits line filterable (for child themes)

Reported by: nathanrice Owned by: nathanrice
Milestone: 3.0 Priority: normal
Severity: normal Version: 3.0
Component: Themes Keywords: twentyten, filter
Focuses: Cc:


Assuming we want people to build child themes based on TwentyTen, it makes sense to allow designers/developers to filter the credits line rather than replace the entire footer.php file.

This patch will allow the line to be filtered.

Attachments (1)

footer.php.diff (856 bytes) - added by nathanrice 6 years ago.
Use an action instead of a filter

Download all attachments as: .zip

Change History (5)

#1 @westi
6 years ago

If a child theme wants to put its own credits in then I think it would do better to over load footer.php or we add a action for additional credits to be added.

Filtering the output of all those translations / sprintf functions for them to be overloaded by a child theme on every page load is just a waste of cycles.

#2 @jorbin
6 years ago

They are already filterable by using the i18n functions. see http://blog.ftwr.co.uk/archives/2010/01/02/mangling-strings-for-fun-and-profit/

6 years ago

Use an action instead of a filter

#3 @nathanrice
6 years ago

Good point. I just re-uploaded and added an action in front of the WP credit text, instead of filtering the entire credits line.

#4 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14433]) Twenty Ten spacing and string cleanups. props zeo, markmcwilliams. see #13198. Add a twentyten_credits filter, props nathanrice, fixes #12804. Also clean up the generator/credits string.

Note: See TracTickets for help on using tickets.