WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13405 closed defect (bug) (fixed)

Install-Helper - Old Code?

Reported by: hakre Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.0
Component: General Keywords: has-patch dev-feedback
Focuses: Cc:

Description

While beta-testing I run over the file install-helper.php. I wonder if that file (last change dec 2008) is still in use.

A quick search on the global variable $wp_only_load_config did reveal that it is not in use any longer.

I have absolutely no idea wether or not this still in use. At least the global variable can be removed.

If anybody else is more into this (three database related functions in there that might be considereable in wpdb class and can make her mind about it, would be great. My patch is only removing the global so far.

Attachments (2)

13405.patch (600 bytes) - added by hakre 5 years ago.
13405-files-by-date-last-changed.txt (20.2 KB) - added by hakre 5 years ago.

Download all attachments as: .zip

Change History (9)

@hakre5 years ago

comment:1 @hakre5 years ago

Related: #11882

comment:2 @hakre5 years ago

I just had the idea to create a listing of all files sorted by date last changed. You find it attached, it's sorted, oldest files on top. Date information taken from current trunk SVN:

svn list -vR

comment:3 @nacin5 years ago

  • Milestone changed from 3.0 to 3.1

Looks like it's a global that was added in #6933. If I had to guess, based on the restructuring that took place, that it was cruft, perhaps indicative of an earlier direction taken by the contributor, and ended up in core.

I doubt any plugin finds a use for it -- it being set versus not set doesn't indicate anything beyond that this file is loaded, and even then its name has no related meaning. The name is what made me realize it came out of when we created wp-load.

This looks fine to me. I'm going to move to 3.1, and we can take care of it early.

comment:4 follow-up: @hakre5 years ago

Do you have an idea for the whole file?

comment:5 in reply to: ↑ 4 @nacin5 years ago

Replying to hakre:

Do you have an idea for the whole file?

Yes, the file itself can be loaded by plugins to perform specific but rare DB tasks, hence it is one of the few APIs in WordPress that need to be loaded manually.

I doubt there are more than a few plugins which actually use it. I've seen some use maybe_create_table() (though dbDelta handles that), etc.

comment:6 @nacin5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [15299]) Remove unused global from install-helper. props hakre, fixes #13405.

comment:7 @nacin5 years ago

  • Milestone changed from Awaiting Triage to 3.1
Note: See TracTickets for help on using tickets.