WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#13539 closed defect (bug) (fixed)

Genericize some more page/post strings

Reported by: nacin Owned by: nacin
Milestone: 3.0 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: needs-patch
Focuses: Cc:

Description


Change History (13)

comment:1 nacin4 years ago

(In [14904]) Generalize some strings. Also tidy the discussions meta box, which will stay as "page" as that is referring to the HTML page, not post/page/book etc. see #13539

comment:2 nacin4 years ago

There's also "Insert into Post"... Tempted to leave as-is until media gets torn up in a future release. We could possibly change that to "Insert into Editor" if UX calls for it.

comment:3 nacin4 years ago

Some other changesets: [14903], [14901]

comment:4 nacin4 years ago

The page attributes box seems hopeless.

Strings include:

  • 'Page Order'
  • 'Pages are usually ordered alphabetically, but you can put a number above to change the order pages appear in.'
  • 'You can arrange your pages in hierarchies. For example, you could have an "About" page that has "Life Story" and "My Dog" pages under it. There are no limits to how deeply nested you can make pages.'
  • 'Page Parent'
  • 'Main Page (no parent)'

comment:5 nacin4 years ago

Idea -- maybe some of those strings (the help text, in particular) can be moved to the help text tabs?

comment:6 sc0ttkclark4 years ago

With the introduction of the new custom post type panels, a whole slew of adjustments must be made to avoid cross-referencing “Post” or “Page” in the UI. Nacin has made a large amount of adjustments for this today, but there are more specifically referencing “page” that I’ve noticed under the “Attributes” section within the “Order” field description “Pages are usually ordered alphabetically, but you can put a number above to change the order pages appear in.” and under the “Discussion” section within the “Allow trackbacks and pingbacks on this page.” checkbox. The use of “page” within these areas should be given additional support for customization by register_post_type.

In addition to this, use of “Insert this Post” buttons throughout the Media Library Thickbox have long been confusing for anyone adding media to “Pages”, with the addition of the new custom post type panels this confusion will only grow. I propose adding additional parameters to the Media Library Thickbox URL that refer to the specific post_type the popup window is to be referencing, and then retrieving a new label within the register_post_type “labels” definition or genericizing them.

comment:7 sc0ttkclark4 years ago

Did it again ;) - in first paragraph I mention label support, I meant to include or 'genericizing them' there as well (like the second paragraph).

comment:8 nacin4 years ago

  • Keywords needs-patch added

Per IRC discussion, we can remove the help text in the page attributes box now that it is in the help tab.

I'm going to then go with "Order", "Parent", and "(no parent)" when the post type is not page. If plugins want more customization than that (i.e. employee's parent is "Supervisor") they can go through the existing gettext filters for now.

Additionally, "Insert into Post" can become Insert Image/Video/Audio.

comment:9 sc0ttkclark4 years ago

Why not "Insert Media"?

comment:10 nacin4 years ago

(In [14938]) In the page attributes box, generalize the screen reader text, also remove the help text which is now in the 'Help' tab. see #13539. subject to final UX review.

comment:11 nacin4 years ago

Going to leave Insert into Post alone for 3.0. Unless we start detecting mime types when deciding what button to show, it's tough to know whether they really uploaded an image. Like "page" when referring to the HTML page, we have used "post" here which just as well could refer to the content or body as it does to the post type. I'm also not convinced on the UX for it and I think Jane would rather test any changes there anyway, even to Insert Media (or any of the others).

Also, keep in mind that if a plugin really wanted to change "Insert into Post," there are filters available to do that.

This ticket can be closed once the page attributes box has been seen by Jane.

Scott, please re-open if you find other strings.

comment:12 zeo4 years ago

At some point, this is really confusing. How about theme?

This is the default if you set a password for Post or Page (see: wp-includes/post-template.php):

This post is password protected. To view it please enter your password below:

And (see: wp-content/themes/twentyten/comments.php):

This post is password protected. Enter the password to view any comments.

use get_post_type?

comment:13 nacin4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [14967]) Call the 'Attributes' meta box 'Page Attributes' for pages. Add some help text. fixes #13539.

Note: See TracTickets for help on using tickets.