get_terms() has 'search' and 'name__like'

[dd32]

Both do similar things:

	if ( !empty($name__like) )
		$where .= " AND t.name LIKE '{$name__like}%'";
...

	if ( !empty($search) ) {
		$search = like_escape($search);
		$where .= " AND (t.name LIKE '%$search%')";
	}

name__like should be removed in favour of search IMO, unless that functionality is intended, and in that case, name__like should get like_escape() applied

[dd32]

in addition to that, Terms are stored in the database htmlspecialchar'd by the looks of it (ie. '&'), The search should take that into consideration and apply the same filtering to the searching term.

[filosofo]

I would prefer removing 'search' instead, as it's unclear what fields are actually being searched.

[dd32]

After thinking a bit more

• name__like should get escaped, and work as it currently does
• search should do both name AND slug, Not sure description is worth it?

[wojtek.szkutnik]

Added diff that includes your suggestions, with search looking for name OR slug. No need to include description IMO.

[wonderboymusic]

Refreshed against trunk, only thing missing from trunk is the search for name AND slug

[wonderboymusic]

.3.diff has unit tests

[nacin]

Looks good.

[wonderboymusic]

In 25164:

Search term name and slug when the search arg is passed to get_terms(). Adds unit test.

Props wojtek.szkutnik.
Fixes #13992.

[boonebgorges]

In 37519:

Tests: get_terms() 'search' test should have more precise fixtures..

Without a fixture that does not match the search term, it's possible for the
test to pass even if the search clause isn't built properly.

See #13992, #35381.