wp_new_comment ignores comment_date_gmt and comment_date

[johneckman]

wp_new_comment takes in a $comment array, but then ignores the comment_date and comment_date_gmt passed into it, instead replacing them with the current time.

It should only set them if the data passed in is empty or not a date/time.

[oso96_2000]

Refreshed patch with unit test

[oso96_2000]

Hey, sorry for taking too long to resolve this. Thanks for the patch @solarissmoke, I just refreshed it and added some unit tests.

[DrewAPicture]

14279.2.diff​ still applies and unit tests pass.

[boonebgorges]

This looks pretty good, but I'm going to make a few changes to clean it up:

• Unit tests can be simplified. Modding the environment during setUp() and tearDown() is likely to have unforeseen effects on other tests in the class.
• I'm going to remove the ! strtotime() checks. I know that this is meant as a sort of validation. But (a) as validation it's imperfect, as it'll fail for the UNIX epoch, and (b) we don't do this kind of validation on dates elsewhere. If someone enters an invalid date, MySQL will convert it to 0000-00-00 00:00:00, which IMO is better behavior than silently swapping out the intended date for the current date.

[boonebgorges]

In 31615:

Respect comment_date and comment_date_gmt params in wp_new_comment().

Props solarissmoke, oso96_2000.
Fixes #14279.