No magic numbers

[ryan]

Add defines for the numeric user_status and comment_status values.

[nacin]

Looks like Ryan forgot to attach a patch here.

[jane]

If someone wants to get this in for 3.1, please post a patch now, as freeze is right around the corner.

[wonderboymusic]

There are magic numbers EVERYWHERE - but mainly, comments and multisite. 14581.diff​ replace thems throughout core with constants: WP_STATUS_ON and WP_STATUS_OFF. Also, it prepares a bunch of SQL queries instead of hard-coding '0' and '1' in them

[DrewAPicture]

As discussed elsewhere with @wonderboymusic, I could definitely see simplifying with something like this, though we'll need to be careful with the verbiage of whatever term we use for "on" and "off".

Perhaps something more like *_ENABLED|DISABLED", or *_TRUE|FALSE`.

[nacin]

I don't love this, to be honest.

[wonderboymusic]

yeah, it's weird

[kitchin]

Note you left single quotes on comment_date_gmt < '%s'" in wp-includes/comment.php line 1093 (scroll to the right to see it):

$sql = $wpdb->prepare(
	"SELECT COUNT(comment_ID) FROM $wpdb->comments WHERE comment_post_ID = %d AND comment_parent = 0 AND comment_approved = %s AND comment_date_gmt < '%s'" . $comtypewhere,
	$comment->comment_post_ID,
	WP_STATUS_ON,
	$comment->comment_date_gmt
);

Also, . $comtypewhere (scroll right further) is confusing within a format string, but I guess that's out of scope of this bug.

[wonderboymusic]

Maybe never

[johnbillion]

WP_STATUS_WONTFIX