WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#15611 closed defect (bug) (fixed)

Admin bar sprite tidy up

Reported by: apeatling Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Graphic Design Keywords: has-patch
Focuses: Cc:

Description

As of r16619 the admin bar sprite needs to be tidied up. A few things:

  • The sprite still includes the WordPress.com logo
  • There are images for the search button - these could probably be removed and changed to CSS
  • The top horizontal and vertical lines are not needed (as far as I'm aware)
  • The checkmark is not used and can be removed
  • The spacing around the images could probably be tightened up

User Darren_ is currently patching this as per our conversation earlier (https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2010-11-29#m210424).

Attachments (8)

admin-bar.dev.css (8.0 KB) - added by darrenmeehan 3 years ago.
admin-bar.dev.css using gradients
15611.diff (3.8 KB) - added by ryan 3 years ago.
admin-bar-sprite-rtl.png (732 bytes) - added by ocean90 3 years ago.
admin-bar-sprite.png (737 bytes) - added by ocean90 3 years ago.
adminbar.patch (13.4 KB) - added by ocean90 3 years ago.
r16897.png (55.6 KB) - added by demetris 3 years ago.
Issues in admin bar after r16897
15611.no.gravatar.patch (3.0 KB) - added by ocean90 3 years ago.
15611.logout.patch (701 bytes) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (28)

comment:1 nacin3 years ago

  • Keywords needs-patch added; admin-bar sprites images removed
  • Milestone changed from Awaiting Review to 3.1

Indeed, let's reduce this sprite to as little as possible.

Also, mentions of it in admin-bar.dev.css should be modified from d=08102010 to ver=yyyymmdd, where that's the date of the commit.

comment:2 nacin3 years ago

I am thinking the search button can be made entirely CSS3. And potentially the main gradient as well.

comment:3 filosofo3 years ago

Since Darren_ is taking out the wp.com logo, maybe he could make the gradient go down another line's worth, so sub-menu hovers can go to 2 lines.

comment:4 apeatling3 years ago

I think the gradients could definitely go CSS, that'll fix the multi-line issue too.

comment:5 darrenmeehan3 years ago

I've removed the need for most of the sprite. The search box is now completely css, as are the gradients. Having some problems with the drop down menus in IE though.

darrenmeehan3 years ago

admin-bar.dev.css using gradients

ryan3 years ago

comment:6 ryan3 years ago

Diffs for admin-bar.dev.css

comment:7 scribu3 years ago

  • Keywords has-patch added; needs-patch removed

comment:8 nacin3 years ago

We need the new sprite image from darrenmeehan.

comment:9 follow-up: ocean903 years ago

We can make the search button and input field with CSS too, have a patch here but it needs a refresh. Wanted?

Also, do we want to support Internet Explorer with the filter hack? We didn't have it for the admin header/footer too.

comment:10 in reply to: ↑ 9 nacin3 years ago

Replying to ocean90:

We can make the search button and input field with CSS too, have a patch here but it needs a refresh. Wanted?

Yeah, let's do it. Would love to not have a single image, personally.

Also, do we want to support Internet Explorer with the filter hack? We didn't have it for the admin header/footer too.

Doesn't matter to me. I imagine it doesn't look so good without the gradient, but then again, if you've ever looked at the admin in IE6...

ocean903 years ago

ocean903 years ago

ocean903 years ago

comment:11 ocean903 years ago

adminbar.patch:

  • removes wp_admin_bar_me_separator() and adds the avatar to wp_admin_bar_my_account_menu() to fix arrow background
  • removes wp_admin_bar_blog_separator() because it's not used, wp.com remain
  • adds some inline docs
  • reduces the sprite through the use of CSS gradient, now only 3 images.

Tested on OS X with Chrome, Safari, Firefox and Windows with IE 6-9, Chrome, Opera, Firefox.

comment:12 ryan3 years ago

(In [16897]) Admin bar sprite cleanups. Props ocean90, darrenmeehan. see #15611

demetris3 years ago

Issues in admin bar after r16897

comment:13 demetris3 years ago

After r16897 the first item and its dropdown have some issues. See attached screenshot.

comment:14 ocean903 years ago

demetris: Thx, I forget to handle no gravatars. Patch is in work.

ocean903 years ago

comment:15 ocean903 years ago

15611.no.gravatar.patch will fix the problem mentioned by demetris.

comment:16 nacin3 years ago

(In [16913]) Fix admin bar styling when no avatars are in use. props ocean90, see #15611.

comment:17 ocean903 years ago

Closing it as fixed.

comment:18 ocean903 years ago

  • Resolution set to fixed
  • Status changed from new to closed

ocean903 years ago

comment:19 ocean903 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 15611.logout.patch. Sorry. :-(

comment:20 westi3 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [16934]) Give the Logout menu item the correct parent so it appears when we have avatars as well as when we don't. Fixes #15611 props ocean90.

Note: See TracTickets for help on using tickets.