Opened 14 years ago
Closed 14 years ago
#15611 closed defect (bug) (fixed)
Admin bar sprite tidy up
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 3.1 | Priority: | normal |
Severity: | normal | Version: | 3.1 |
Component: | Graphic Design | Keywords: | has-patch |
Focuses: | Cc: |
Description
As of r16619 the admin bar sprite needs to be tidied up. A few things:
- The sprite still includes the WordPress.com logo
- There are images for the search button - these could probably be removed and changed to CSS
- The top horizontal and vertical lines are not needed (as far as I'm aware)
- The checkmark is not used and can be removed
- The spacing around the images could probably be tightened up
User Darren_ is currently patching this as per our conversation earlier (https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2010-11-29#m210424).
Attachments (8)
Change History (28)
#1
@
14 years ago
- Keywords needs-patch added; admin-bar sprites images removed
- Milestone changed from Awaiting Review to 3.1
#2
@
14 years ago
I am thinking the search button can be made entirely CSS3. And potentially the main gradient as well.
#3
@
14 years ago
Since Darren_
is taking out the wp.com logo, maybe he could make the gradient go down another line's worth, so sub-menu hovers can go to 2 lines.
#4
@
14 years ago
I think the gradients could definitely go CSS, that'll fix the multi-line issue too.
#5
@
14 years ago
I've removed the need for most of the sprite. The search box is now completely css, as are the gradients. Having some problems with the drop down menus in IE though.
#9
follow-up:
↓ 10
@
14 years ago
We can make the search button and input field with CSS too, have a patch here but it needs a refresh. Wanted?
Also, do we want to support Internet Explorer with the filter hack? We didn't have it for the admin header/footer too.
#10
in reply to:
↑ 9
@
14 years ago
Replying to ocean90:
We can make the search button and input field with CSS too, have a patch here but it needs a refresh. Wanted?
Yeah, let's do it. Would love to not have a single image, personally.
Also, do we want to support Internet Explorer with the filter hack? We didn't have it for the admin header/footer too.
Doesn't matter to me. I imagine it doesn't look so good without the gradient, but then again, if you've ever looked at the admin in IE6...
#11
@
14 years ago
adminbar.patch:
- removes wp_admin_bar_me_separator() and adds the avatar to wp_admin_bar_my_account_menu() to fix arrow background
- removes wp_admin_bar_blog_separator() because it's not used, wp.com remain
- adds some inline docs
- reduces the sprite through the use of CSS gradient, now only 3 images.
Tested on OS X with Chrome, Safari, Firefox and Windows with IE 6-9, Chrome, Opera, Firefox.
#13
@
14 years ago
After r16897 the first item and its dropdown have some issues. See attached screenshot.
Indeed, let's reduce this sprite to as little as possible.
Also, mentions of it in admin-bar.dev.css should be modified from d=08102010 to ver=yyyymmdd, where that's the date of the commit.