WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#16178 closed defect (bug) (fixed)

TwentyTen: Fix Clear-Floats Issue on Paginated Posts

Reported by: chipbennett Owned by:
Milestone: 3.1 Priority: normal
Severity: normal Version: 3.1
Component: Themes Keywords:
Focuses: Cc:

Description

TwentyTen does not properly clear floats between the_content() and wp_link_pages(), such that, on paginated posts, if the last element in the_content() is floated (e.g. a floated image), the output from wp_list_pages() renders next to, rather than below, the floated element.

Simple fix: add clear:both to the definition of the CSS class "page-link" that is applied to the container DIV for wp_link_pages() output.

Attachments (1)

style.css.diff (358 bytes) - added by chipbennett 3 years ago.
Fixes TwentyTen style.css to add "clear:both" to .page-link class

Download all attachments as: .zip

Change History (7)

chipbennett3 years ago

Fixes TwentyTen style.css to add "clear:both" to .page-link class

comment:1 nacin3 years ago

  • Cc lancewillett iandstewart added

Will need to hear from Lance and Ian on this. Seems okay.

comment:2 iandstewart3 years ago

Looks good to me.

comment:3 chipbennett3 years ago

Any reason for this not to get pushed into TwentyTen for 3.1?

comment:4 nacin3 years ago

  • Milestone changed from Awaiting Review to 3.1

Didn't see Ian's comment. Going in.

comment:5 nacin3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [17331]) Clear floats before page links in Twenty Ten. props chipbennett, fixes #16178.

comment:6 chipbennett3 years ago

Woot!

Thanks, Nacin.

Note: See TracTickets for help on using tickets.