Context Navigation

← Previous Ticket
Next Ticket →

#16865 closed enhancement (fixed)

'post' definition should use menu_position

Reported by:	scribu	Owned by:	wonderboymusic
Priority:	normal	Milestone:	4.4
Component:	Administration	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

Since WP 3.1, we don't need to hardcode the Posts $menu array, since register_post_type() is flexible enough to handle it.

Attachments (3)

16865.diff (4.0 KB ) - added by scribu 15 years ago.
16865.2.diff (6.2 KB ) - added by scribu 15 years ago.: enclosing function
16865.3.diff (6.9 KB ) - added by wonderboymusic 11 years ago.

Download all attachments as: .zip

Change History (12)

@scribu
15 years ago

Attachment 16865.diff added

@scribu
15 years ago

Attachment 16865.2.diff added

enclosing function

#1 @scribu
15 years ago

16865.2.diff wraps most of the code in an enclosing function, so that we don't have to worry about polluting the global namespace with temporary vars anymore.

Last edited 15 years ago by scribu (previous) (diff)

#2 @scribu
15 years ago

Milestone Awaiting Review → Future Release

#3 @chriscct7
12 years ago

Keywords needs-refresh added; has-patch removed

#4 @wonderboymusic
11 years ago

Keywords has-patch added; needs-refresh removed
Milestone Future Release → 4.4

16865.3.diff refreshes this. Posts and Pages can opt in via menu_position when registering the post type. Requires a few things in the post type loop below

@wonderboymusic
11 years ago

Attachment 16865.3.diff added

#5 @wonderboymusic
11 years ago

Owner set to wonderboymusic
Resolution → fixed
Status new → closed

In 33723:

With a few modifications in wp-admin/menu.php, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare menu_position on post type registration.

Props scribu, wonderboymusic.
Fixes #16865.

#6 @ryan
11 years ago

Related?

Notice: Undefined variable: i in /.../wp-admin/menu.php on line 57

This ticket was mentioned in Slack in #core by boren. View the logs.

11 years ago

#8 @wonderboymusic
11 years ago

In 33867:

After [33723], ensure that $i is properly set before looping.

See #16865.

#9 @obenland
11 years ago

In 35590:

Menu: Continue to use post dashicon as default menu icon.

Prevents a bug where custom post types without a specified menu icon would
adopt the menu icon of the preceding post type. Introduced in [33723].

See #16865.
Fixes #34637.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#16865 closed enhancement (fixed)

'post' definition should use menu_position

Description

Attachments (3)

Change History (12)

@scribu 15 years ago

@scribu 15 years ago

#1 @scribu 15 years ago

#2 @scribu 15 years ago

#3 @chriscct7 12 years ago

#4 @wonderboymusic 11 years ago

@wonderboymusic 11 years ago

#5 @wonderboymusic 11 years ago

#6 @ryan 11 years ago

This ticket was mentioned in ​Slack in #core by boren. ​View the logs. 11 years ago

#8 @wonderboymusic 11 years ago

#9 @obenland 11 years ago

Download in other formats:

@scribu
15 years ago

@scribu
15 years ago

#1 @scribu
15 years ago

#2 @scribu
15 years ago

#3 @chriscct7
12 years ago

#4 @wonderboymusic
11 years ago

@wonderboymusic
11 years ago

#5 @wonderboymusic
11 years ago

#6 @ryan
11 years ago

This ticket was mentioned in Slack in #core by boren. View the logs.

11 years ago

#8 @wonderboymusic
11 years ago

#9 @obenland
11 years ago