'post' definition should use menu_position

[scribu]

Since WP 3.1, we don't need to hardcode the Posts $menu array, since register_post_type() is flexible enough to handle it.

[scribu]

enclosing function

[scribu]

[16865.2.diff] wraps most of the code in an enclosing function, so that we don't have to worry about polluting the global namespace with temporary vars anymore.

[wonderboymusic]

16865.3.diff​ refreshes this. Posts and Pages can opt in via menu_position when registering the post type. Requires a few things in the post type loop below

[wonderboymusic]

In 33723:

With a few modifications in wp-admin/menu.php, we can eliminate the extra logic for Post and Page menu registration. Instead, they can just declare menu_position on post type registration.

Props scribu, wonderboymusic.
Fixes #16865.

[ryan]

Related?

Notice: Undefined variable: i in /.../wp-admin/menu.php on line 57

[wonderboymusic]

In 33867:

After [33723], ensure that $i is properly set before looping.

See #16865.

[obenland]

In 35590:

Menu: Continue to use post dashicon as default menu icon.

Prevents a bug where custom post types without a specified menu icon would
adopt the menu icon of the preceding post type. Introduced in [33723].

See #16865.
Fixes #34637.