WordPress.org

Make WordPress Core

Opened 11 years ago

Closed 5 years ago

#16876 closed enhancement (worksforme)

Separate msgid "Post" from wp-includes/post.php:1154 for the administration menu and custom menu creation screen

Reported by: waclawjacek Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: I18N Keywords: has-patch needs-refresh
Focuses: Cc:

Description

Hey! It seems that both the custom menu creation screen and the administration menu bar are using the same translation. Could you please separate them? Here's the relevant bit of tags/3.1/wordpress.pot:

 2700 #: wp-includes/post.php:1154
 2701 msgctxt "post type singular name"
 2702 msgid "Post"
 2703 msgstr ""
 2704 
 2705 #: wp-includes/post.php:1154
 2706 msgctxt "post type singular name"
 2707 msgid "Page"
 2708 msgstr ""

Cheers!
WJ

Attachments (1)

16876.patch (3.1 KB) - added by SergeyBiryukov 10 years ago.

Download all attachments as: .zip

Change History (11)

#1 follow-up: @SergeyBiryukov
10 years ago

  • Keywords reporter-feedback added

The only solution I see is to add another key to get_post_type_labels().

What are we trying to fix here? Do post type labels in Polish need a separate context for the Menus screen?

#2 in reply to: ↑ 1 @waclawjacek
10 years ago

Replying to SergeyBiryukov:

What are we trying to fix here? Do post type labels in Polish need a separate context for the Menus screen?

Yes, this is exactly the problem.

The only solution I see is to add another key to get_post_type_labels().

Another solution would probably be to simply change either of the contexts to something else, so the strings don't get merged into one in .pot files.

Thanks,
Wacław

#3 follow-up: @SergeyBiryukov
10 years ago

  • Keywords has-patch added; reporter-feedback removed

get_post_type_labels() is where all the post type label contexts are listed.

For consistency, I've added menu item type context to taxonomies as well.

#4 in reply to: ↑ 3 @waclawjacek
10 years ago

Replying to SergeyBiryukov:

get_post_type_labels() is where all the post type label contexts are listed.

For consistency, I've added menu item type context to taxonomies as well.

Sounds good! Thanks! :)

#5 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 3.3

#6 follow-up: @ryan
10 years ago

  • Milestone changed from 3.3 to Future Release

The label proliferation is getting out of hand. Let's punt this to 3.4 and see if we can come up with alternatives.

#7 in reply to: ↑ 6 @nacin
10 years ago

Replying to ryan:

The label proliferation is getting out of hand. Let's punt this to 3.4 and see if we can come up with alternatives.

Agreed.

#8 @chriscct7
7 years ago

@nacin did you come up with a system for that?

Patch looks good to go otherwise

#9 @chriscct7
6 years ago

  • Keywords needs-refresh added

#10 @SergeyBiryukov
5 years ago

  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from new to closed

No traction and no similar requests in 5 years, I think it's safe to close this.

Feel free to reopen if still relevant.

Note: See TracTickets for help on using tickets.