WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 11 years ago

Last modified 11 years ago

#16943 closed enhancement (maybelater)

Code Cleanup add_query_arg() + friends

Reported by: hakre's profile hakre Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch needs-refresh needs-unit-tests
Focuses: Cc:

Description

This should reduce the complexity of add_query_arg() a bit.

This is partially related to PHP 5 stuff (#16918,#16920) we can make use of now.

Originated in #16932

Related: #16942

Attachments (1)

16943.patch​ (5.8 KB) - added by hakre 14 years ago.
add_query_arg() + friends

Download all attachments as: .zip

Change History (8)

@hakre
14 years ago

add_query_arg() + friends

#1 @hakre
14 years ago

Tested and Benchmarked. Looks good from my point of view for a first patch.

#2 @dd32
14 years ago

Could we get some unit tests for those changes?

#3 @dd32
14 years ago

  • Keywords needs-unit-tests added

#4 @hakre
14 years ago

You can find some functional tests here: ​https://gist.github.com/882734

#5 @c3mdigital
11 years ago

  • Keywords close added; has-patch needs-unit-tests removed
  • Resolution set to maybelater
  • Status changed from new to closed

Closing as maybe later. See: ​http://make.wordpress.org/core/2011/03/23/code-refactoring/

#6 @ocean90
11 years ago

  • Keywords needs-refresh added; close removed
  • Milestone Awaiting Review deleted

#7 @SergeyBiryukov
11 years ago

  • Keywords has-patch needs-unit-tests added
Note: See TracTickets for help on using tickets.