WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 8 months ago

Last modified 8 months ago

#16943 closed enhancement (maybelater)

Code Cleanup add_query_arg() + friends

Reported by: hakre Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.1
Component: General Keywords: has-patch needs-refresh needs-unit-tests
Focuses: Cc:

Description

This should reduce the complexity of add_query_arg() a bit.

This is partially related to PHP 5 stuff (#16918,#16920) we can make use of now.

Originated in #16932

Related: #16942

Attachments (1)

16943.patch (5.8 KB) - added by hakre 3 years ago.
add_query_arg() + friends

Download all attachments as: .zip

Change History (8)

hakre3 years ago

add_query_arg() + friends

comment:1 hakre3 years ago

Tested and Benchmarked. Looks good from my point of view for a first patch.

comment:2 dd323 years ago

Could we get some unit tests for those changes?

comment:3 dd323 years ago

  • Keywords needs-unit-tests added

comment:4 hakre3 years ago

You can find some functional tests here: https://gist.github.com/882734

comment:5 c3mdigital8 months ago

  • Keywords close added; has-patch needs-unit-tests removed
  • Resolution set to maybelater
  • Status changed from new to closed

comment:6 ocean908 months ago

  • Keywords needs-refresh added; close removed
  • Milestone Awaiting Review deleted

comment:7 SergeyBiryukov8 months ago

  • Keywords has-patch needs-unit-tests added
Note: See TracTickets for help on using tickets.