Make WordPress Core

Opened 19 years ago

Closed 19 years ago

Last modified 17 years ago

#1774 closed defect (bug) (fixed)

removing redundant line in source:trunk/wp-admin/edit-comments.php#2832

Reported by: johnjosephbachir's profile johnjosephbachir Owned by: markjaquith's profile markjaquith
Milestone: Priority: low
Severity: minor Version: 1.6
Component: Optimization Keywords: bg|has-patch bg|commit bg|squashed
Focuses: Cc:

Description

Unless my tired eyes are missing something obvious, i think this extra permissions check is completely redundant (maybe there used to be a discrepency between the two cases?).

diff for source:trunk/wp-admin/edit-comments.php :

Index: edit-comments.php
===================================================================
--- edit-comments.php	(revision 2955)
+++ edit-comments.php	(working copy)
@@ -95,8 +95,6 @@
         <p><?php _e('Posted'); echo ' '; comment_date('M j, g:i A');  
 			if ( current_user_can('edit_post', $comment->comment_post_ID) ) {
 				echo " | <a href=\"post.php?action=editcomment&amp;comment=".$comment->comment_ID."\">" . __('Edit Comment') . "</a>";
-			}
-			if ( current_user_can('edit_post', $comment->comment_post_ID) ) {
 				echo " | <a href=\"post.php?action=deletecomment&amp;p=".$comment->comment_post_ID."&amp;comment=".$comment->comment_ID."\" onclick=\"return deleteSomething( 'comment', $comment->comment_ID, '" . sprintf(__("You are about to delete this comment by &quot;%s&quot;.\\n&quot;Cancel&quot; to stop, &quot;OK&quot; to delete."), wp_specialchars( $comment->comment_author, 1 ))  . "' );\">" . __('Delete Comment') . "</a> &#8212; ";
 			} // end if any comments to show
 			// Get post title

Attachments (1)

edit-comments.php.diff (1018 bytes) - added by johnjosephbachir 19 years ago.
diff for source:trunk/wp-admin/edit-comments.php#2832

Download all attachments as: .zip

Change History (6)

#1 @johnjosephbachir
19 years ago

  • Summary changed from removing redundant line in source:trunk/wp-admin/edit-comments.php to removing redundant line in source:trunk/wp-admin/edit-comments.php#2832

#2 @markjaquith
19 years ago

  • Keywords bg|has-patch bg|commit added
  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

Nah, that wouldn't have changed after the first echo. Nice catch.

#3 @skippy
19 years ago

  • Keywords bg|squashed added

#4 @ryan
19 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3036]) Remove redundant lines. Props johnjosephbachir. fixes #1774

#5 @(none)
17 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.