Opened 14 years ago
Closed 12 years ago
#17802 closed defect (bug) (fixed)
In gallery sorting, the Order header doesnt align with the Order textbox
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 3.5 | Priority: | normal |
Severity: | normal | Version: | 3.1 |
Component: | Media | Keywords: | has-patch ui-feedback |
Focuses: | Cc: |
Description (last modified by )
As reported by rasheed as part of #17790, the Order textbox on the Gallery Sorting screen isn't aligned to the header, instead, it's shown under Actions.
This page is a bit strange, in the sense that the header of the table is a table, whereas the rows are divs.
for how it looks in RTL, see this file, pretty much the same in ltr, just fliped around.. (Note, It's not RTL specific)
Attachments (2)
Change History (11)
#3
@
13 years ago
Here's another take on it, which is to keep the table header widths as is and make the div column widths match. It uses 19841.diff from #19841 by mitchoyoshitaka with one small additional margin change.
#7
follow-up:
↓ 8
@
13 years ago
- Cc tomaugerdotcom@… added
At the end of the day, probably the right thing to do is to change the sortables to TRs and make sure everything sits within the table structure set out by the header. That's the only way we can be sure the columns will align in all l10n situations where the header text or the action text may expand.
I'll work up a patch in the next few days. Looks like you can do ui-sortables on TR elements as long as you include a TBODY.
If you change the width of the '#media-upload th.actions-head' and '#media-upload th.order-head' in media.css and media.dev.css down to 10% each the headers then appear above the columns that they relate to.
This patch makes that change.