WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 8 years ago

#17852 closed enhancement (worksforme)

Collapsed menu fly-out headers should be clickable

Reported by: nacin Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: accessibility Cc:

Description (last modified by nacin)

When you hover over a collapsed admin menu icon, the extension of the icon is not clickable, only the submenu screens are.

This is the same behavior in 2.7 to 3.1, but I think it should be considered.

Attachments (6)

collapsed-menu-link.patch (126.8 KB) - added by JarretC 10 years ago.
17852.patch (1.1 KB) - added by SergeyBiryukov 10 years ago.
17852.2.patch (1.1 KB) - added by SergeyBiryukov 10 years ago.
Refreshed patch
17852.3.patch (1.2 KB) - added by SergeyBiryukov 10 years ago.
Fixed active submenu header color
17852.after.png (28.6 KB) - added by SergeyBiryukov 10 years ago.
With 17852.3.patch
17852.diff (4.5 KB) - added by nacin 10 years ago.

Download all attachments as: .zip

Change History (18)

#1 @JarretC
10 years ago

  • Cc jarretcade@… added

First time doing this so hope I did that right.

Still needs some tweaking, especially in older versions of IE (as usual). Also, had to use !important to get the highlighting to override so that needs to be taken care of as well. But it is a start :)

#2 @SergeyBiryukov
10 years ago

  • Keywords has-patch ui-feedback added

Refreshed and slightly changed the patch:

  • Removed highlighting of submenu header links
  • Preserved current height of submenu headers

!important is still needed, since that's the way background color is defined in color schemes:
http://core.trac.wordpress.org/browser/tags/3.2.1/wp-admin/css/colors-fresh.dev.css#L1291

#3 @sorich87
10 years ago

  • Type changed from defect (bug) to enhancement

#4 @DrewAPicture
10 years ago

  • Cc xoodrew@… added

+1 for this.

@SergeyBiryukov
10 years ago

Refreshed patch

@SergeyBiryukov
10 years ago

Fixed active submenu header color

@SergeyBiryukov
10 years ago

With 17852.3.patch

#5 @SergeyBiryukov
10 years ago

Refreshed the patch and added screenshot.

#6 @nacin
10 years ago

  • Description modified (diff)

#7 @jane
10 years ago

I would prefer the header link to be clickable.

#8 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 3.4

#9 @sabreuse
10 years ago

  • Cc sabreuse@… added

@nacin
10 years ago

#10 @nacin
10 years ago

  • Milestone changed from 3.4 to Future Release

17852.diff is a quick-and-dirty patch. More work is going to be needed to get this right.

#11 @garthkoyle
8 years ago

I tested this in Chrome, FireFox and Safari for OSX. The link of the flyout extension for each icon seems to be working fine.

I'll try to confirm the same browsers work for Windows.

#12 @ocean90
8 years ago

  • Focuses accessibility added
  • Keywords ui-feedback removed
  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.