Need a way to override wp_link_query()

[philfreo]

In previous versions of WordPress, we were able to write a plugin which called add_filter on tiny_mce_before_init and then we were able to specify external_link_list_url which we gave it a list of all of the URLs on our site (we primarily linked to non-WordPress URLs on our site from this tool). Then when an author created a Link in the post tool the little popup would include a dropdown of all of the URLs/page titles that we specified.

In WordPress 3.2 you have the new fancy "link to existing content" feature in the popup.

The problem is that there is NO hook, filter, or pluggable function whatsoever to allow you to override the functionality of this.

I needed to make the search results box return a list of pages (urls and titles) that I specified from a different database. In order order to do that I had to re-create the entire wp_link_query() function from wp-admin/includes/internal-linking.php to make it return search results from my own database. I put that function into a Plugin (to keep it out of Core) but then I had to hack core to rename wp_link_query() to wp_link_query_ORIGINAL() to get it to use my function and not the existing one.

Either wp_link_query() needs to be a pluggable function or there need to be hooks that let you completely replace how it works.

[nacin]

We definitely need hooks here. +1

[dd32]

The version field is used to track when a bug was first reported.

[bainternet]

@dd32yea sorry about that,


anyway +1 for either hooks or pluggable.

[hereswhatidid]

Definitely +1 for a hook or pluggable. Need a way to add items other than just published posts to the list of available items to link to.

[nohalfpixels]

is there a date set for updating this feature?

[DrewAPicture]

#19718 closed as duplicate

[heinrichgeps]

Definitely +1 for a hook or pluggable.

[rliverman]

Agreed, unfortunately looks like a core hack for the time being...ugh. +1 for hook or pluggable.

[SergeyBiryukov]

Duplicate: #21033

[ocean90]

Duplicate: #21861

[goldenapples]

Since #21861 was closed, I've moved @CoenJacobs's patch from that ticket here. Also added a filter on the return value so plugins can rearrange the order that custom post types appear in the returned array.

[bradyvercher]

A hook would definitely be nice here.

I developed a plugin a few months ago (​Better Internal Link Search), without realizing this ticket existed, to modify the results and ended up having to filter the AJAX request and recreate a bit of wp_link_query(). The plugin adds a whole lot of useful features and improvements and can be easily extended for anyone that needs this functionality right away. If any of it looks useful for core, I'm happy to help learn how to contribute.

[SergeyBiryukov]

#23241 was marked as a duplicate.

[lumpysimon]

+1 for this making it into 3.6

[SergeyBiryukov]

18042.2.diff​ passes $query to the resulting filter too.

[DrewAPicture]

Both filters added in 18042.2.diff​ work as expected for me. +1

[dominicp]

+1. The patches looks great to me too. Can't really see a downside to this.

[CoenJacobs]

Replying to SergeyBiryukov:

18042.2.diff​ passes $query to the resulting filter too.

Thanks, I've tested this patch against the current trunk, still works like a charm.

Just curious: Any reason you prefer wp_link_query over wp_link_query_results in my original modified patch as posted here? Just because that's the function name, best practice to filter results via a similarly named filter?

[SergeyBiryukov]

#15349 was marked as a duplicate.

[SergeyBiryukov]

Replying to CoenJacobs:

Just curious: Any reason you prefer wp_link_query over wp_link_query_results in my original modified patch as posted here? Just because that's the function name, best practice to filter results via a similarly named filter?

Yes, this appears to be the pattern throughout the core.

[SergeyBiryukov]

In 25293:

Add 'wp_link_query_args' and 'wp_link_query' filters to allow for customizing the internal linking dialog. props CoenJacobs, goldenapples. fixes #18042.

[DrewAPicture]

filter docs

[DrewAPicture]

From this point moving forward, any time we introduce new functions, filters, actions, methods, properties, etc., a ticket shouldn't be marked as closed/fixed until inline docs accompany whatever was introduced.

18042-docs.diff​ adds docblocks for the wp_link_query_args and wp_link_query filters introduced in [25293].

[DrewAPicture]

Associative array.

[DrewAPicture]

18042-docs.2.diff​ fixes $results param in wp_link_query as it's actually an associative array.

[DrewAPicture]

point to WP_Query for args

[SergeyBiryukov]

Replying to DrewAPicture:

From this point moving forward, any time we introduce new functions, filters, actions, methods, properties, etc., a ticket shouldn't be marked as closed/fixed until inline docs accompany whatever was introduced.

Right, my bad.

[SergeyBiryukov]

In 25299:

Document 'wp_link_query_args' and 'wp_link_query' filters. props DrewAPicture. fixes #18042.