Make WordPress Core

Opened 13 years ago

Closed 9 years ago

#18517 closed defect (bug) (fixed)

Visual Feedback for Nav Menu UI

Reported by: sterlo's profile sterlo Owned by: helen's profile helen
Milestone: 4.3 Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch needs-refresh
Focuses: ui, javascript Cc:


Currently if you go to:

Then click the plus sign to add a Menu and then without putting a menu name in, click create menu, it gives you a visual indicator that you've missed a critical bit of data.

But, if you try to add a Custom Link to an existing menu: If one forgets to add a URL and just adds a label then tries to save it, there is not 'tactile feedback'. It just sits there not doing anything.

It should probably be consistent with how the rest of the UI behaves.

Attachments (1)

18517.diff (1.1 KB) - added by pragunbhutani 11 years ago.

Download all attachments as: .zip

Change History (9)

#1 @nacin
12 years ago

  • Keywords needs-patch added
  • Type changed from enhancement to defect (bug)
  • Version changed from 3.3 to 3.0


#2 @jane
12 years ago

Agreed, though it needs visual feedback, not tactile.

#3 @helenyhou
11 years ago

  • Component changed from UI to Menus
  • Summary changed from Tactile Feedback for Nav Menu UI to Visual Feedback for Nav Menu UI

11 years ago

#4 @pragunbhutani
11 years ago

I've added an addClass('form-invalid') to the event handler in nav-menu.js
Also updated class definition for .form-invalid to include .customLinkDiv

#5 @helen
10 years ago

  • Focuses ui javascript added
  • Keywords has-patch needs-refresh added; needs-patch removed

This ticket was mentioned in Slack in #core by nacin. View the logs.

9 years ago

#7 @helen
9 years ago

  • Milestone changed from Awaiting Review to 4.3

#8 @helen
9 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 32690:

Nav menus: Provide visual feedback when attempting to add an empty custom link.

props pragunbhutani for the initial patch.
fixes #18517.

Note: See TracTickets for help on using tickets.