WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 8 weeks ago

#18517 new defect (bug)

Visual Feedback for Nav Menu UI

Reported by: sterlo Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.0
Component: Menus Keywords: has-patch needs-refresh
Focuses: ui, javascript Cc:

Description

Currently if you go to:
/wp-admin/nav-menus.php

Then click the plus sign to add a Menu and then without putting a menu name in, click create menu, it gives you a visual indicator that you've missed a critical bit of data.

But, if you try to add a Custom Link to an existing menu: If one forgets to add a URL and just adds a label then tries to save it, there is not 'tactile feedback'. It just sits there not doing anything.

It should probably be consistent with how the rest of the UI behaves.

Attachments (1)

18517.diff (1.1 KB) - added by pragunbhutani 12 months ago.

Download all attachments as: .zip

Change History (6)

comment:1 nacin2 years ago

  • Keywords needs-patch added
  • Type changed from enhancement to defect (bug)
  • Version changed from 3.3 to 3.0

Agreed.

comment:2 jane2 years ago

Agreed, though it needs visual feedback, not tactile.

comment:3 helenyhou18 months ago

  • Component changed from UI to Menus
  • Summary changed from Tactile Feedback for Nav Menu UI to Visual Feedback for Nav Menu UI

pragunbhutani12 months ago

comment:4 pragunbhutani12 months ago

I've added an addClass('form-invalid') to the event handler in nav-menu.js
Also updated class definition for .form-invalid to include .customLinkDiv

comment:5 helen8 weeks ago

  • Focuses ui javascript added
  • Keywords has-patch needs-refresh added; needs-patch removed
Note: See TracTickets for help on using tickets.