WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 3 months ago

#18788 new enhancement

Remove redundant type attributes from script and style tags

Reported by: solarissmoke Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.3
Component: Script Loader Keywords: 3.4-early has-patch
Focuses: administration Cc:

Description

Now that the admin is using the HTML5 doctype everywhere, the type="text/javascript" and type="text/css" attributes on script and style tags are unnecessary (if they weren't anyway), and I think they can be safely removed to trim a few hundred bytes from core. Should be a simple search and replace exercise.

Attachments (2)

no-cdata.diff (10.2 KB) - added by tw2113 2 years ago.
removed script CDATA tags. Left script types on though.
no-cdata1.diff (12.2 KB) - added by tw2113 2 years ago.
forgot wp-includes

Download all attachments as: .zip

Change History (11)

comment:1 azaozz3 years ago

  • Keywords 3.4 added
  • Milestone changed from Awaiting Review to Future Release

We have to confirm that first for older mobile browsers. They still might be needed for some. Also the //<![CDATA[ bits inside of <script> are not needed.

comment:2 tw21132 years ago

  • Cc michael.d.beckwith@… added

tw21132 years ago

removed script CDATA tags. Left script types on though.

tw21132 years ago

forgot wp-includes

comment:3 tw21132 years ago

  • Keywords has-patch added

I did my best to stick to just <script></script> blocks. I didn't edit any of them in RSS/XML based feed files.

comment:4 retlehs15 months ago

  • Cc retlehs added

comment:5 Volker_E.13 months ago

  • Cc Volker_E. added

comment:6 SergeyBiryukov12 months ago

  • Keywords 3.4 removed

HTML comment tags in wp-admin/includes/file.php can also be removed:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-admin/includes/file.php#L969

comment:7 SergeyBiryukov12 months ago

  • Keywords 3.4-early added

Fixing the keyword for reference.

comment:9 nacin3 months ago

  • Component changed from Administration to Script Loader
  • Focuses administration added
Note: See TracTickets for help on using tickets.