WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 8 months ago

Last modified 8 months ago

#19397 closed enhancement (invalid)

Missing hide-if-js class on gallery items

Reported by: scribu Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Media Keywords:
Focuses: Cc:

Description

When you open the gallery tab in the media thickbox, next to each attachment item you have an input in which you can enter an order.

The thing is that thse attachments can be ordered via drag-and-drop, so there's no need to show the inputs to users that have JavaScript enabled.

Not to mention that the order column header is way off.

Attachments (2)

50.png (45.6 KB) - added by scribu 2 years ago.
19397.diff (1.5 KB) - added by scribu 2 years ago.

Download all attachments as: .zip

Change History (11)

scribu2 years ago

comment:1 follow-up: dd322 years ago

If you use the "Sort" options at the top, it doesn't currently re-order the items, just the numbers IIRC (There's another trac ticket for this recently)

scribu2 years ago

comment:2 in reply to: ↑ 1 scribu2 years ago

Replying to dd32:

If you use the "Sort" options at the top, it doesn't currently re-order the items, just the numbers IIRC (There's another trac ticket for this recently)

Since we have drag-and-drop, those links seem completely useless to me. We should remove them altogether.

comment:3 scribu2 years ago

Or just remove the clear link and make them sort the items themselves based on their title. If you could find that ticket, that would be useful.

comment:4 dd322 years ago

If you could find that ticket, that would be useful.

Unfortunately, It doesn't look like it's a trac ticket, It must've been a comment elsewhere.

Problem description I was thinking of: Selecting an ordering in the header should result in the items being shuffled rather than just the numbers updating.

comment:5 follow-up: azaozz2 years ago

It's not that simple. This sets the "menu_order" on the attachment posts. That ordering works similarly to tabindex in HTML: you can have several posts with the same menu_order, all will be placed at the top and sorted by uploaded date/time (or another secondary ordering parameter like post_name). So the "manual entry" fields are needed.

Agree that the UI is very minimal and doesn't come close to making that intuitive but at the same time this is an advanced feature that the great majority of users would never need to access. Hoping these advanced sorting options will be handled much better when we redo the gallery.

comment:6 in reply to: ↑ 5 scribu2 years ago

Replying to azaozz:

Agree that the UI is very minimal and doesn't come close to making that intuitive but at the same time this is an advanced feature that the great majority of users would never need to access.

Exactly. Move it to a plugin.

comment:7 mitchoyoshitaka2 years ago

  • Cc mitcho@… added

comment:8 avryl8 months ago

  • Resolution set to invalid
  • Status changed from new to closed

Media has been redone in 3.5.

comment:9 helen8 months ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.