Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#19481 closed defect (bug) (fixed)

Unused strings in edit-form-advanced.php since WP 1.0

Reported by: ocean90's profile ocean90 Owned by: nacin's profile nacin
Milestone: 3.4 Priority: normal
Severity: normal Version: 1.2
Component: Comments Keywords: has-patch commit
Focuses: Cc:

Description

After reviewing the German translation files I found two strings in edit-form-advanced.php which seems like they aren't used since version 1.0 anymore.

$submitbutton_text = __('Edit Comment');
$toprow_title = sprintf(__('Editing Comment # %s'), $comment->comment_ID);

The last reference was in 0.71, see attached file.

Attachments (3)

b2edit.form.php (6.1 KB) - added by ocean90 12 years ago.
0.71 file
19481.patch (683 bytes) - added by ocean90 12 years ago.
19481.2.patch (1.6 KB) - added by ocean90 12 years ago.
* Removes strings * Removes bad vars

Download all attachments as: .zip

Change History (7)

@ocean90
12 years ago

0.71 file

@ocean90
12 years ago

@ocean90
12 years ago

  • Removes strings * Removes bad vars

#1 @ocean90
12 years ago

  • Keywords 3.4-early added

#2 @nacin
12 years ago

  • Keywords commit added; 3.4-early removed
  • Milestone changed from Awaiting Review to 3.4

#3 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19612]:

Remove dead variables and strings from edit-form-comment. props ocean90, fixes #19481.

#4 @nacin
12 years ago

Typo cleared up in #19801.

Note: See TracTickets for help on using tickets.