Multi-site Upload Limit Stuck at 50MB

[wspnut]

Hey all,

This has been confirmed by multiple users. After upgrading to WP3.3, all sites on the multi-site, except for the initial site / (or /blog/) are stuck at a 50MB upload limit, if upload limiting is enabled.

This took effect as soon as the upgrade to WP3.3 was complete. Changing the site's individual upload limit, as well as changing the network-wide limit, took no effect. This occurs with all plugins disabled, as well.

This is a critical bug for us, as our sites cannot upload any media with the cap so low.

[wpmuguru]

What value are you filling in for the limit?

[wspnut]

Network setting was set to "1024" (no quotes)

Per-site setting I tried with both "100" and a blank value

[wpmuguru]

I entered those values in my dev install and the dashboard of the subsite says 100MB of space.

If I leave the option empty on the individual site I do get the 50MB.

[SergeyBiryukov]

Related: #18119

[wspnut]

Patch fixed it. Thanks wpmugru.

[wpmuguru]

19538.2.diff also retains the support for the 0 upload limit.

[anointed]

Patch solved the problem for me. Thank you wpmugru!

[ocean90]

Related: #18119/r19314

[nacin]

19538.hotfix.diff​ is a patch for the Hotfix plugin. Can someone test?

[nacin]

We're doing === '' and === false to avoid catching '0' / 0, I imagine. In that case, we can just move to is_numeric().

[nacin]

In [19639]:

Better checking for values for multisite upload limits. see #19538 for trunk.

[nacin]

Marking as commit for the 3.3 branch, after additional review.

[wpmuguru]

That looks fine to me.

[nacin]

[19639] means that a site option of 0 will enforce the 0. While it makes it consistent, I don't know if that's a good change for a point release.

[nacin]

This broke some unit tests. We should also add new ones to account for any changes.

[ryan]

In [19645]:

Better checking for values for multisite upload limits. fixes #19538 for 3.3

[nacin]

Re-opening for comment:14 and comment:15. I would like to change back to empty() || is_numeric() for the second conditional for 3.3.1 only, as that attempt at standardization can introduce a change in behavior.

[nacin]

In [19652]:

Revert half of [19639]. If the blog_upload_space site_option is '0', restore 50 as a default. see #19538.

[nacin]

The piece reverted in [19652] looked good. However, it introduces a change in a point release that could disable uploads for an entire network. Let's not include that in the 3.3 branch.

[nacin]

In [19654]:

Revert half of [19639]. If the blog_upload_space site_option is '0', restore 50 as a default. see #19538 for 3.3.

[nacin]

Any further fixes should be a new ticket for 3.4.