Allow array for $extra_fields in request_filesystem_credentials

[griffinjt]

The current implementation for passing extra fields through request_filesystem_credentials() does not allow for an array of data to be passed. I came across this issue when trying to process a bulk installation of plugins with my plugin installation class. My patch fixes this from what I can tell and doesn't break anything that I can see from my testing.

[griffinjt]

allow array of data to be passed through $extra_fields

[dd32]

That'll issue a PHP Notice on any $extra_fields which aren't in the incoming $_POST array. That's why there's a isset() call there

[griffinjt]

updated to fix notices

[griffinjt]

It's late - forgive me. :-) That should fix the error warnings now and still works fine as far as I have tested.

[GaryJ]

Instead of doing an is_array() check and duplicating the echo line, why not cast $_POST['field'] to an array and just have the foreach?

[griffinjt]

Doing that won't allow for the input name attribute to be set as an array. That's why I had the two echo lines.

[griffinjt]

Any word on this? Again with testing I haven't run into any bugs and it works perfectly for passing an array of data from a previous post entry.

[dd32]

Any word on this?

Most of us are taking a break after 3.3's release. 3.4 dev will be starting after the holiday season and people will look over it then most likely. Have patience.

[griffinjt]

Ok,cool. No worries!

[wpsmith]

+1

[griffinjt]

Ok, here's my feeble attempt at providing a solution that will catch any type of value submitted via $extra_fields and parse it correctly within the input field. Because my knowledge of recursion is shoddy at best, I came up with this function instead.

All it does is sanitize and store all the data passed via $extra_fields into an array and then builds a query string based on that data. Then I just run through the query string and make input fields.

It works in all my testing. I don't know if this is the -best- method, but it is a -working- method that can at least get the ball rolling so that no data is lost when attempting to pass it once the user hits "Proceed".

[griffinjt]

callback function to accept any type of extra field

[griffinjt]

Just updated the patch to use (the newly discovered to me) WP's build_query function. Would love to get some feedback on this - no more losing data when having to enter FTP credentials. :-)

[kurtpayne]

Alternate patch - handles multi-dimensional arrays

[kurtpayne]

Submitting an alternate patch. This will handle multi-dimensional arrays, too. E.g.

<input type="hidden" name="field1[]" value="value1" />
<input type="hidden" name="field1[]" value="value2" />
<input type="hidden" name="field1[]" value="value3" />
<input type="hidden" name="field2[deep][array][value]" value="value4" />
<input type="hidden" name="field3[][][]" value="value5" />
<input type="hidden" name="field4" value="value6" />

And the corresponding php:

$form_fields = array ( 'field1', 'field2', 'field3', 'field4' );
request_filesystem_credentials($url, $method, false, false, $form_fields) );

I'm testing this with ​Otto's test filesystem plugin.

[wonderboymusic]

#28207 was marked as a duplicate.

[jrf]

Wondering what the status is of this. Ran into this bug myself as well.

Code-wise, I'm in favour of @kurtpayne's patch, through I'd prefer to see the array_print as a proper function to stay in line with most other WP code.

[DrewAPicture]

@dd32: Care to follow up here?

[dd32]

Before considering any changes here, we'll be best off seeing what happens with the inline-install #29820.
This screen is mostly going to disappear, or need to be rewritten for that I believe.

[jrf]

@dd32 I'm not sure I understand why as file read/writes can need to be done quite legitimately outside of the context of plugin installation. This is about the FileSystem API, not necessarily about plugin installation/upgrade etc.

[jrf]

What can be done to move this forward ?

[SirLouen]

Replying to griffinjt:

I came across this issue when trying to process a bulk installation of plugins with my plugin

Installation class.

After the comment of @dd32 I'm wondering

1. Is this report still valid?
2. Can we provide a minimal 2-plugin installation sample/use-case code to test this behaviour? (also would be nice to at least comment on a potential unit-test)
3. For the last patch, that create_function is deprecated, also I don't think that a lambda function is ideal in this case where you are actually calling the function without the need of use or anything like that.

More work is needed in this report before asking for testing.