WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#20051 closed defect (bug) (fixed)

Kill debug_fwrite(), log_app(), logIO()

Reported by: nacin Owned by:
Milestone: 3.4 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: Cc:

Description

Three super-old logging functions for enclosures, APP, and XML-RPC, respectively. Let's nuke them.

Attachments (1)

20051.diff (22.5 KB) - added by nacin 4 years ago.

Download all attachments as: .zip

Change History (9)

@nacin4 years ago

comment:1 @nacin4 years ago

  • Keywords has-patch added

comment:2 @kurtpayne4 years ago

+1. Happy to see these go. What is best practice moving forward? error_log() ?

comment:3 @duck_4 years ago

Agreed. Should debug_fwrite() check the $debug global like log_IO and log_app do with $app_logging and $xmlrpc_logging? Maybe even switch to WP_DEBUG instead.

comment:4 follow-up: @kawauso4 years ago

s/erorr_log/error_log on line 825 of the patch / line 76 of patched xmlrpc.php

comment:5 in reply to: ↑ 4 @nacin4 years ago

Replying to kawauso:

s/erorr_log/error_log on line 825 of the patch / line 76 of patched xmlrpc.php

Thanks. Caught that locally, haven't posted a patch yet.

comment:6 @nacin4 years ago

In [19935]:

Deprecate ancient "debugging" tools.

  • logIO() and the global $xmlrpc_logging in XML-RPC.
  • log_app() and the global $app_logging in APP.
  • debug_fwrite(), debug_fopen(), debug_fclose(), and $debug.

see #20051.

comment:7 @nacin3 years ago

  • Resolution set to fixed
  • Status changed from new to closed

comment:8 @ocean903 years ago

Typo in r19935, see #20670.

Note: See TracTickets for help on using tickets.