Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#20149 closed defect (bug) (invalid)

Del button should work the same in Visual & HTML Editors

Reported by: aaroncampbell's profile aaroncampbell Owned by:
Milestone: Priority: normal
Severity: minor Version: 3.3
Component: Editor Keywords:
Focuses: Cc:


If you highlight something in the visual editor and click strikethrough (del) it wraps the content in <del> tags. If you do the same in the HTML editor it gets wrapped in <del> tags with the datetime parameter filled with what looks like an ISO 8601 date.


<del>Deleted from Visual</del>

<del datetime="2012-03-01T13:56:01+00:00">Deleted from HTML</del>

We should standardize these.

One of the side effects of this is that the del button in the HTML editor can't be used in captions because it messes up the quotes (#18311).

Attachments (1)

20149.diff (1.6 KB) - added by sushkov 12 years ago.

Download all attachments as: .zip

Change History (12)

#1 @azaozz
12 years ago

The same is true for the <ins> tag. The datetime attribute for <del> and <ins> doesn't seem to be displayed or used by the browsers so removing them wouldn't affect anything.

12 years ago

#2 @sushkov
12 years ago

  • Cc stas@… added
  • Keywords has-patch added

#3 @aaroncampbell
12 years ago

  • Cc aaroncampbell added

#4 @jane
12 years ago

Fine with removing the timestamp if it makes things easier. Easy enough to add datetime with a plugin if someone really wants that attribute.

#5 @jane
12 years ago

  • Milestone changed from Awaiting Review to 3.4

#6 @aaroncampbell
12 years ago

  • Keywords commit added; 2nd-opinion removed

This patch looks good to go.

#7 @westi
12 years ago

I think removing the timestamp here is a retrograde move and would rather we didn't regress this.

#8 @nacin
12 years ago

If captions are breaking we need to fix captions, not this.

#9 @aaroncampbell
12 years ago

  • Keywords has-patch commit removed
  • Resolution set to invalid
  • Status changed from new to closed

We're going to fix captions instead of regressing here

#10 @helenyhou
12 years ago

  • Milestone 3.4 deleted

#11 @mark-k
11 years ago

  • Cc mark@… added
  • Severity changed from normal to minor

IMO this is wrong. Semantically ( the del tag have less meaning without the deletion time. I guess it is OK if WordPress do not make it easy to provide the info at all, but to provide it in the less used editor component while ignoring the more used one is strange.

related #23321

Note: See TracTickets for help on using tickets.