Make WordPress Core

Opened 13 years ago

Closed 11 years ago

#20251 closed defect (bug) (fixed)

get_preferred_from_update_core can return false

Reported by: markoheijnen's profile markoheijnen Owned by: nacin's profile nacin
Milestone: 3.9 Priority: low
Severity: minor Version:
Component: Upgrade/Install Keywords: has-patch commit
Focuses: docs Cc:

Description

I just had a case in my network installation where get_site_transient( 'update_core' ) returned false.
In this case it gave an error message at core_update_footer();

When I went back to Network admin updates page and press 'check_again' the error went away.
The error can be caused because of running the recent nightly build (3.4-alpha-20205).

What was weird that in the site wp-admin there still was the balloon that there was an update when I had the error. When I pressed the button the balloon went away what is the correct.

Attachments (1)

20251.patch (1.1 KB) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (5)

#1 @nacin
11 years ago

  • Component changed from General to Upgrade/Install
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Severity changed from normal to minor

#2 @ocean90
11 years ago

  • Keywords reporter-feedback added

To which error message you're referring? Could it be a duplicate of #21716?

#3 @SergeyBiryukov
11 years ago

  • Focuses docs added
  • Keywords has-patch commit added; needs-patch reporter-feedback removed
  • Milestone changed from Future Release to 3.9

The warning indeed sounds like the one fixed in [21815], but let's document that both get_preferred_from_update_core() and get_core_updates() return false on failure.

#4 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27264:

Clarify return values for get_preferred_from_update_core() and get_core_updates().

props SergeyBiryukov.
fixes #20251.

Note: See TracTickets for help on using tickets.